[wpan-next,v2,0/4] ieee802154: Active scan support

Message

Miquel Raynal March 10, 2023, 2:53 p.m. UTC

Hello,
Following the initial support for passive scan and beaconing, here is an
addition to support active scans.
Thanks,
Miquèl

Changes in v2:
* None, just resending the series after -rc1, now that all the late
  changes have been included in Linus' tree.

Miquel Raynal (4):
  ieee802154: Add support for user active scan requests
  mac802154: Handle active scanning
  ieee802154: Add support for allowing to answer BEACON_REQ
  mac802154: Handle received BEACON_REQ

 include/net/ieee802154_netdev.h | 20 +++++++++-
 net/ieee802154/header_ops.c     | 36 +++++++++++++++++
 net/ieee802154/nl802154.c       |  3 +-
 net/mac802154/ieee802154_i.h    | 21 ++++++++++
 net/mac802154/main.c            |  2 +
 net/mac802154/rx.c              | 70 ++++++++++++++++++++++++++++++++-
 net/mac802154/scan.c            | 68 +++++++++++++++++++++++++++++---
 7 files changed, 211 insertions(+), 9 deletions(-)

Comments

Alexander Aring March 23, 2023, 12:58 p.m. UTC | #1

Hi,

On Fri, Mar 10, 2023 at 10:12 AM Miquel Raynal
<[e-mail]> wrote:
>
> Hello,
> Following the initial support for passive scan and beaconing, here is an
> addition to support active scans.
> Thanks,
> Miquèl

Acked-by: Alexander Aring <[e-mail]>

but I need to admit those are more scan mechanism related work and I
trust Miquel he does the right thing, because he is actually more into
this topic as me and worked previously on it.
For me, I do not see anything that will break something e.g.
overwriting framebuffer/dealing with frame filter levels and I am
pretty sure Miquel already knows to take care of it.

Even if there would later be a problem regarding that, we can
hopefully work things out.

Thanks.

Sorry for the late reply.

- Alex

Stefan Schmidt March 23, 2023, 8:56 p.m. UTC | #2

Hello.

On 23.03.23 13:58, Alexander Aring wrote:
> Hi,
> 
> On Fri, Mar 10, 2023 at 10:12 AM Miquel Raynal
> <[e-mail]> wrote:
>>
>> Hello,
>> Following the initial support for passive scan and beaconing, here is an
>> addition to support active scans.
>> Thanks,
>> Miquèl
> 
> Acked-by: Alexander Aring <[e-mail]>

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt

Miquel Raynal March 24, 2023, 9:57 a.m. UTC | #3

Hi,

[e-mail] wrote on Thu, 23 Mar 2023 08:58:43 -0400:

> Hi,
> 
> On Fri, Mar 10, 2023 at 10:12 AM Miquel Raynal
> <[e-mail]> wrote:
> >
> > Hello,
> > Following the initial support for passive scan and beaconing, here is an
> > addition to support active scans.
> > Thanks,
> > Miquèl  
> 
> Acked-by: Alexander Aring <[e-mail]>
> 
> but I need to admit those are more scan mechanism related work and I
> trust Miquel he does the right thing, because he is actually more into
> this topic as me and worked previously on it.
> For me, I do not see anything that will break something e.g.
> overwriting framebuffer/dealing with frame filter levels and I am
> pretty sure Miquel already knows to take care of it.

I agree with the fact that the risk is rather low on this one. Now
coming:
- Handling of limited devices (ca8210)
- Associations/dis-associations (+ additional care to avoid confusing
  the devices)

> 
> Even if there would later be a problem regarding that, we can
> hopefully work things out.

Of course.

> 
> Thanks.
> 
> Sorry for the late reply.
> 
> - Alex
> 


Thanks!
Miquèl

Alexander Aring March 24, 2023, 12:27 p.m. UTC | #4

Hi,

On Fri, Mar 24, 2023 at 5:57 AM Miquel Raynal <[e-mail]> wrote:
>
> Hi,
>
> [e-mail] wrote on Thu, 23 Mar 2023 08:58:43 -0400:
>
> > Hi,
> >
> > On Fri, Mar 10, 2023 at 10:12 AM Miquel Raynal
> > <[e-mail]> wrote:
> > >
> > > Hello,
> > > Following the initial support for passive scan and beaconing, here is an
> > > addition to support active scans.
> > > Thanks,
> > > Miquèl
> >
> > Acked-by: Alexander Aring <[e-mail]>
> >
> > but I need to admit those are more scan mechanism related work and I
> > trust Miquel he does the right thing, because he is actually more into
> > this topic as me and worked previously on it.
> > For me, I do not see anything that will break something e.g.
> > overwriting framebuffer/dealing with frame filter levels and I am
> > pretty sure Miquel already knows to take care of it.
>
> I agree with the fact that the risk is rather low on this one. Now
> coming:
> - Handling of limited devices (ca8210)
> - Associations/dis-associations (+ additional care to avoid confusing
>   the devices)
>

ok. Thanks for the update.

- Alex