| Message ID | 20250219125039.18024-1-shaw.leon@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: Improve netns handling in rtnetlink | expand |
On Wed, 19 Feb 2025 20:50:26 +0800 Xiao Liang wrote: > Patch 01 avoids link name conflict in different netns. > > To achieve 2), there're mainly 3 steps: > > - Patch 02 packs newlink() parameters into a struct, including > the original "src_net" along with more netns context. No semantic > changes are introduced. > - Patch 03 ~ 09 converts device drivers to use the explicit netns > extracted from params. > - Patch 10 ~ 11 removes the old netns parameter, and converts > rtnetlink to create device in target netns directly. > > Patch 12 ~ 13 adds some tests for link name and link netns. Nice work, thank you!
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 19 Feb 2025 20:50:26 +0800 you wrote: > This patch series includes some netns-related improvements and fixes for > rtnetlink, to make link creation more intuitive: > > 1) Creating link in another net namespace doesn't conflict with link > names in current one. > 2) Refector rtnetlink link creation. Create link in target namespace > directly. > > [...] Here is the summary with links: - [net-next,v10,01/13] rtnetlink: Lookup device in target netns when creating link https://git.kernel.org/netdev/net-next/c/ec061546c6cf - [net-next,v10,02/13] rtnetlink: Pack newlink() params into struct https://git.kernel.org/netdev/net-next/c/69c7be1b903f - [net-next,v10,03/13] net: Use link/peer netns in newlink() of rtnl_link_ops https://git.kernel.org/netdev/net-next/c/cf517ac16ad9 - [net-next,v10,04/13] ieee802154: 6lowpan: Validate link netns in newlink() of rtnl_link_ops https://git.kernel.org/netdev/net-next/c/3533717581dd - [net-next,v10,05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init() https://git.kernel.org/netdev/net-next/c/9e17b2a1a097 - [net-next,v10,06/13] net: ip_tunnel: Use link netns in newlink() of rtnl_link_ops https://git.kernel.org/netdev/net-next/c/eacb1160536e - [net-next,v10,07/13] net: ipv6: Init tunnel link-netns before registering dev https://git.kernel.org/netdev/net-next/c/db014522f356 - [net-next,v10,08/13] net: ipv6: Use link netns in newlink() of rtnl_link_ops https://git.kernel.org/netdev/net-next/c/5e72ce3e3980 - [net-next,v10,09/13] net: xfrm: Use link netns in newlink() of rtnl_link_ops https://git.kernel.org/netdev/net-next/c/5314e3d68455 - [net-next,v10,10/13] rtnetlink: Remove "net" from newlink params https://git.kernel.org/netdev/net-next/c/9c0fc091dc01 - [net-next,v10,11/13] rtnetlink: Create link directly in target net namespace https://git.kernel.org/netdev/net-next/c/7ca486d08a30 - [net-next,v10,12/13] selftests: net: Add python context manager for netns entering https://git.kernel.org/netdev/net-next/c/030329416232 - [net-next,v10,13/13] selftests: net: Add test cases for link and peer netns https://git.kernel.org/netdev/net-next/c/85cb3711acb8 You are awesome, thank you!
This patch series includes some netns-related improvements and fixes for rtnetlink, to make link creation more intuitive: 1) Creating link in another net namespace doesn't conflict with link names in current one. 2) Refector rtnetlink link creation. Create link in target namespace directly. So that # ip link add netns ns1 link-netns ns2 tun0 type gre ... will create tun0 in ns1, rather than create it in ns2 and move to ns1. And don't conflict with another interface named "tun0" in current netns. Patch 01 avoids link name conflict in different netns. To achieve 2), there're mainly 3 steps: - Patch 02 packs newlink() parameters into a struct, including the original "src_net" along with more netns context. No semantic changes are introduced. - Patch 03 ~ 09 converts device drivers to use the explicit netns extracted from params. - Patch 10 ~ 11 removes the old netns parameter, and converts rtnetlink to create device in target netns directly. Patch 12 ~ 13 adds some tests for link name and link netns. --- BTW please note there're some issues found in current code: - In amt_newlink() drivers/net/amt.c: amt->net = net; ... amt->stream_dev = dev_get_by_index(net, ... Uses net, but amt_lookup_upper_dev() only searches in dev_net. So the AMT device may not be properly deleted if it's in a different netns from lower dev. - In lowpan_newlink() in net/ieee802154/6lowpan/core.c: wdev = dev_get_by_index(dev_net(ldev), nla_get_u32(tb[IFLA_LINK])); Looks for IFLA_LINK in dev_net, but in theory the ifindex is defined in link netns. And thanks to Kuniyuki for fixing related issues in gtp and pfcp: https://lore.kernel.org/netdev/20250110014754.33847-1-kuniyu@amazon.com/ --- v10: - Move link/peer net helper functions to from patch 02 to 03. - Remove redundant tunnel->net assignment for IPv4 tunnels (patch 05). - Initialize tunnel->net before calling register_netdevice() for IPv6 tunnels (patch 07). - Coding style fixes. v9: link: https://lore.kernel.org/all/20250210133002.883422-1-shaw.leon@gmail.com/ - Change the prototype of macvlan_common_newlink(). - Minor fixes of coding style and local variables. v8: link: https://lore.kernel.org/all/20250113143719.7948-1-shaw.leon@gmail.com/ - Move dev and ext_ack out from param struct. - Validate link_net and dev_net are identical for 6lowpan. v7: link: https://lore.kernel.org/all/20250104125732.17335-1-shaw.leon@gmail.com/ - Add selftest kconfig. - Remove a duplicated test of ip6gre. v6: link: https://lore.kernel.org/all/20241218130909.2173-1-shaw.leon@gmail.com/ - Split prototype, driver and rtnetlink changes. - Add more tests for link netns. - Fix IPv6 tunnel net overwriten in ndo_init(). - Reorder variable declarations. - Exclude a ip_tunnel-specific patch. v5: link: https://lore.kernel.org/all/20241209140151.231257-1-shaw.leon@gmail.com/ - Fix function doc in batman-adv. - Include peer_net in rtnl newlink parameters. v4: link: https://lore.kernel.org/all/20241118143244.1773-1-shaw.leon@gmail.com/ - Pack newlink() parameters to a single struct. - Use ynl async_msg_queue.empty() in selftest. v3: link: https://lore.kernel.org/all/20241113125715.150201-1-shaw.leon@gmail.com/ - Drop "netns_atomic" flag and module parameter. Add netns parameter to newlink() instead, and convert drivers accordingly. - Move python NetNSEnter helper to net selftest lib. v2: link: https://lore.kernel.org/all/20241107133004.7469-1-shaw.leon@gmail.com/ - Check NLM_F_EXCL to ensure only link creation is affected. - Add self tests for link name/ifindex conflict and notifications in different netns. - Changes in dummy driver and ynl in order to add the test case. v1: link: https://lore.kernel.org/all/20241023023146.372653-1-shaw.leon@gmail.com/ Xiao Liang (13): rtnetlink: Lookup device in target netns when creating link rtnetlink: Pack newlink() params into struct net: Use link/peer netns in newlink() of rtnl_link_ops ieee802154: 6lowpan: Validate link netns in newlink() of rtnl_link_ops net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init() net: ip_tunnel: Use link netns in newlink() of rtnl_link_ops net: ipv6: Init tunnel link-netns before registering dev net: ipv6: Use link netns in newlink() of rtnl_link_ops net: xfrm: Use link netns in newlink() of rtnl_link_ops rtnetlink: Remove "net" from newlink params rtnetlink: Create link directly in target net namespace selftests: net: Add python context manager for netns entering selftests: net: Add test cases for link and peer netns drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 9 +- drivers/net/amt.c | 11 +- drivers/net/bareudp.c | 9 +- drivers/net/bonding/bond_netlink.c | 6 +- drivers/net/can/dev/netlink.c | 4 +- drivers/net/can/vxcan.c | 7 +- .../ethernet/qualcomm/rmnet/rmnet_config.c | 9 +- drivers/net/geneve.c | 9 +- drivers/net/gtp.c | 10 +- drivers/net/ipvlan/ipvlan.h | 3 +- drivers/net/ipvlan/ipvlan_main.c | 8 +- drivers/net/ipvlan/ipvtap.c | 6 +- drivers/net/macsec.c | 9 +- drivers/net/macvlan.c | 21 +-- drivers/net/macvtap.c | 6 +- drivers/net/netkit.c | 14 +- drivers/net/pfcp.c | 9 +- drivers/net/ppp/ppp_generic.c | 9 +- drivers/net/team/team_core.c | 6 +- drivers/net/veth.c | 7 +- drivers/net/vrf.c | 5 +- drivers/net/vxlan/vxlan_core.c | 9 +- drivers/net/wireguard/device.c | 7 +- drivers/net/wireless/virtual/virt_wifi.c | 8 +- drivers/net/wwan/wwan_core.c | 16 +- include/linux/if_macvlan.h | 6 +- include/net/ip_tunnels.h | 5 +- include/net/rtnetlink.h | 40 ++++- net/8021q/vlan_netlink.c | 9 +- net/batman-adv/soft-interface.c | 9 +- net/bridge/br_netlink.c | 6 +- net/caif/chnl_net.c | 5 +- net/core/rtnetlink.c | 34 +++-- net/hsr/hsr_netlink.c | 12 +- net/ieee802154/6lowpan/core.c | 7 +- net/ipv4/ip_gre.c | 22 ++- net/ipv4/ip_tunnel.c | 7 +- net/ipv4/ip_vti.c | 9 +- net/ipv4/ipip.c | 9 +- net/ipv6/ip6_gre.c | 26 ++-- net/ipv6/ip6_tunnel.c | 18 ++- net/ipv6/ip6_vti.c | 14 +- net/ipv6/sit.c | 20 ++- net/xfrm/xfrm_interface_core.c | 15 +- tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/config | 5 + .../testing/selftests/net/lib/py/__init__.py | 2 +- tools/testing/selftests/net/lib/py/netns.py | 18 +++ tools/testing/selftests/net/link_netns.py | 141 ++++++++++++++++++ tools/testing/selftests/net/netns-name.sh | 10 ++ 50 files changed, 486 insertions(+), 181 deletions(-) create mode 100755 tools/testing/selftests/net/link_netns.py