From patchwork Fri Sep 22 12:13:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Schmidt X-Patchwork-Id: 9965943 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6A892600C5 for ; Fri, 22 Sep 2017 12:14:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50EAF2988E for ; Fri, 22 Sep 2017 12:14:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 45D1229894; Fri, 22 Sep 2017 12:14:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3894F2988E for ; Fri, 22 Sep 2017 12:14:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbdIVMOZ (ORCPT ); Fri, 22 Sep 2017 08:14:25 -0400 Received: from proxima.lasnet.de ([78.47.171.185]:54866 "EHLO proxima.lasnet.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752302AbdIVMOY (ORCPT ); Fri, 22 Sep 2017 08:14:24 -0400 Received: from work.Speedport_W_724V_09011603_05_010 (pD9F78968.dip0.t-ipconnect.de [217.247.137.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: stefan@sostec.de) by proxima.lasnet.de (Postfix) with ESMTPSA id 0C359C6769; Fri, 22 Sep 2017 14:14:23 +0200 (CEST) From: Stefan Schmidt To: linux-wpan@vger.kernel.org Cc: Alexander Aring , michael.hennerich@analog.com, h.morris@cascoda.com, linuxdev@cascoda.com, varkabhadram@gmail.com, alan@signal11.us, Stefan Schmidt Subject: [PATCH 08/14] ieee802154: mrf24j40: fix some kernel coding style errors Date: Fri, 22 Sep 2017 14:13:59 +0200 Message-Id: <20170922121405.31789-9-stefan@osg.samsung.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170922121405.31789-1-stefan@osg.samsung.com> References: <20170922121405.31789-1-stefan@osg.samsung.com> Sender: linux-wpan-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wpan@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix format of multi-line comments and long lines. Signed-off-by: Stefan Schmidt --- drivers/net/ieee802154/mrf24j40.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c index ee7084b2d52d..e951a191e15d 100644 --- a/drivers/net/ieee802154/mrf24j40.c +++ b/drivers/net/ieee802154/mrf24j40.c @@ -569,8 +569,9 @@ static void write_tx_buf_complete(void *context) } /* This function relies on an undocumented write method. Once a write command - and address is set, as many bytes of data as desired can be clocked into - the device. The datasheet only shows setting one byte at a time. */ + * and address is set, as many bytes of data as desired can be clocked into + * the device. The datasheet only shows setting one byte at a time. + */ static int write_tx_buf(struct mrf24j40 *devrec, u16 reg, const u8 *data, size_t length) { @@ -578,9 +579,10 @@ static int write_tx_buf(struct mrf24j40 *devrec, u16 reg, int ret; /* Range check the length. 2 bytes are used for the length fields.*/ - if (length > TX_FIFO_SIZE-2) { - dev_err(printdev(devrec), "write_tx_buf() was passed too large a buffer. Performing short write.\n"); - length = TX_FIFO_SIZE-2; + if (length > TX_FIFO_SIZE - 2) { + dev_err(printdev(devrec), "%s: passed buffer to large, short write\n", + __func__); + length = TX_FIFO_SIZE - 2; } cmd = MRF24J40_WRITELONG(reg); @@ -1073,7 +1075,8 @@ static int mrf24j40_hw_init(struct mrf24j40 *devrec) int ret; /* Initialize the device. - From datasheet section 3.2: Initialization. */ + * From datasheet section 3.2: Initialization. + */ ret = regmap_write(devrec->regmap_short, REG_SOFTRST, 0x07); if (ret) goto err_ret; @@ -1374,7 +1377,8 @@ static int mrf24j40_remove(struct spi_device *spi) ieee802154_unregister_hw(devrec->hw); ieee802154_free_hw(devrec->hw); /* TODO: Will ieee802154_free_device() wait until ->xmit() is - * complete? */ + * complete? + */ return 0; }