| Message ID | 20180530214732.1021121-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hello Arnd, Thanks for the fix. Acked-by: Xue Liu <liuxuenetmail@gmail.com> On Wed, 30 May 2018 at 23:47, Arnd Bergmann <arnd@arndb.de> wrote: > > Without CONFIG_GPIOLIB, some headers are not included implicitly, > leading to a build failure: > > drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe': > drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration] > > This includes gpio/consumer.h and irq.h directly rather through the > gpiolib header. > > Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ieee802154/mcr20a.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c > index de0d7f28a181..e428277781ac 100644 > --- a/drivers/net/ieee802154/mcr20a.c > +++ b/drivers/net/ieee802154/mcr20a.c > @@ -15,10 +15,11 @@ > */ > #include <linux/kernel.h> > #include <linux/module.h> > -#include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/spi/spi.h> > #include <linux/workqueue.h> > #include <linux/interrupt.h> > +#include <linux/irq.h> > #include <linux/skbuff.h> > #include <linux/of_gpio.h> > #include <linux/regmap.h> > -- > 2.9.0 > -- -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. [Sorry for the delay here, I was on a few weeks on leave] On 30.05.2018 23:47, Arnd Bergmann wrote: > Without CONFIG_GPIOLIB, some headers are not included implicitly, > leading to a build failure: > > drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe': > drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration] > > This includes gpio/consumer.h and irq.h directly rather through the > gpiolib header. > > Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ieee802154/mcr20a.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c > index de0d7f28a181..e428277781ac 100644 > --- a/drivers/net/ieee802154/mcr20a.c > +++ b/drivers/net/ieee802154/mcr20a.c > @@ -15,10 +15,11 @@ > */ > #include <linux/kernel.h> > #include <linux/module.h> > -#include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/spi/spi.h> > #include <linux/workqueue.h> > #include <linux/interrupt.h> > +#include <linux/irq.h> > #include <linux/skbuff.h> > #include <linux/of_gpio.h> > #include <linux/regmap.h> > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt -- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index de0d7f28a181..e428277781ac 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -15,10 +15,11 @@ */ #include <linux/kernel.h> #include <linux/module.h> -#include <linux/gpio.h> +#include <linux/gpio/consumer.h> #include <linux/spi/spi.h> #include <linux/workqueue.h> #include <linux/interrupt.h> +#include <linux/irq.h> #include <linux/skbuff.h> #include <linux/of_gpio.h> #include <linux/regmap.h>
Without CONFIG_GPIOLIB, some headers are not included implicitly, leading to a build failure: drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe': drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration] This includes gpio/consumer.h and irq.h directly rather through the gpiolib header. Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ieee802154/mcr20a.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)