@@ -262,19 +262,16 @@ static void atusb_tx_done(struct atusb *atusb, u8 seq)
u8 expect = atusb->tx_ack_seq;
dev_dbg(&usb_dev->dev, "%s (0x%02x/0x%02x)\n", __func__, seq, expect);
- if (seq == expect) {
- /* TODO check for ifs handling in firmware */
- ieee802154_xmit_complete(atusb->hw, atusb->tx_skb, false);
- } else {
- /* TODO I experience this case when atusb has a tx complete
- * irq before probing, we should fix the firmware it's an
- * unlikely case now that seq == expect is then true, but can
- * happen and fail with a tx_skb = NULL;
- */
- ieee802154_wake_queue(atusb->hw);
- if (atusb->tx_skb)
- dev_kfree_skb_irq(atusb->tx_skb);
- }
+
+ /* TODO:
+ * seq == expect: Check for ifs handling in firmware.
+ * seq != expect: I experience this case when atusb has a tx complete
+ * irq before probing, we should fix the firmware it's an unlikely case
+ * now that seq == expect is then true, but can happen and fail with a
+ * tx_skb = NULL;
+ */
+
+ ieee802154_xmit_complete(atusb->hw, atusb->tx_skb, false);
}
static void atusb_in_good(struct urb *urb)
ieee802154_xmit_complete() is the right helper to call when a transmission is over. The fact that it completed or not is not really a question, but drivers must tell the core that the completion is over, even if it was canceled. Do not call ieee802154_wake_queue() manually, in order to let full control of this task to the core. Here the skb is freed with a particular helper because it is done in irq context. It is not necessary to do that as the *_xmit_complete() helper will handle it properly anyway. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/net/ieee802154/atusb.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-)