| Message ID | 20241020112313.53174-2-thorsten.blum@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [net-next] ieee802154: Replace BOOL_TO_STR() with str_true_false() | expand |
Hi Thorsten, thorsten.blum@linux.dev wrote on Sun, 20 Oct 2024 13:23:13 +0200: > Replace the custom BOOL_TO_STR() macro with the str_true_false() helper > function and remove the macro. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
Hello Thorsten Blum. On Sun, 20 Oct 2024 13:23:13 +0200, Thorsten Blum wrote: > Replace the custom BOOL_TO_STR() macro with the str_true_false() helper > function and remove the macro. > > Applied to wpan/wpan-next.git, thanks! [1/1] ieee802154: Replace BOOL_TO_STR() with str_true_false() https://git.kernel.org/wpan/wpan-next/c/299875256571 regards, Stefan Schmidt
Hi Stefan, > On 28. Oct 2024, at 16:57, Stefan Schmidt wrote: > > Hello Thorsten Blum. > > On Sun, 20 Oct 2024 13:23:13 +0200, Thorsten Blum wrote: >> Replace the custom BOOL_TO_STR() macro with the str_true_false() helper >> function and remove the macro. >> >> > > Applied to wpan/wpan-next.git, thanks! > > [1/1] ieee802154: Replace BOOL_TO_STR() with str_true_false() > https://git.kernel.org/wpan/wpan-next/c/299875256571 I'm actually not sure this works after getting feedback on a similar patch [1]. I'd probably revert it to be safe. Thanks, Thorsten [1] https://lore.kernel.org/linux-kernel/afe1839843d8d4dd38dd9368b2e30f0aa6864b9a.camel@sipsolutions.net/
Hello. On 28.10.24 17:42, Thorsten Blum wrote: > Hi Stefan, > >> On 28. Oct 2024, at 16:57, Stefan Schmidt wrote: >> >> Hello Thorsten Blum. >> >> On Sun, 20 Oct 2024 13:23:13 +0200, Thorsten Blum wrote: >>> Replace the custom BOOL_TO_STR() macro with the str_true_false() helper >>> function and remove the macro. >>> >>> >> >> Applied to wpan/wpan-next.git, thanks! >> >> [1/1] ieee802154: Replace BOOL_TO_STR() with str_true_false() >> https://git.kernel.org/wpan/wpan-next/c/299875256571 > > I'm actually not sure this works after getting feedback on a similar > patch [1]. That is unfortunate. > I'd probably revert it to be safe. I removed it completely now, as it has not been part of any pull request yet. regards Stefan Schmidt
diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h index 591ce0a16fc0..284b63a0834e 100644 --- a/net/ieee802154/trace.h +++ b/net/ieee802154/trace.h @@ -35,8 +35,6 @@ #define WPAN_CCA_PR_FMT "cca_mode: %d, cca_opt: %d" #define WPAN_CCA_PR_ARG __entry->cca_mode, __entry->cca_opt -#define BOOL_TO_STR(bo) (bo) ? "true" : "false" - /************************************************************* * rdev->ops traces * *************************************************************/ @@ -273,7 +271,7 @@ TRACE_EVENT(802154_rdev_set_lbt_mode, ), TP_printk(WPAN_PHY_PR_FMT ", " WPAN_DEV_PR_FMT ", lbt mode: %s", WPAN_PHY_PR_ARG, - WPAN_DEV_PR_ARG, BOOL_TO_STR(__entry->mode)) + WPAN_DEV_PR_ARG, str_true_false(__entry->mode)) ); TRACE_EVENT(802154_rdev_set_ackreq_default, @@ -292,7 +290,7 @@ TRACE_EVENT(802154_rdev_set_ackreq_default, ), TP_printk(WPAN_PHY_PR_FMT ", " WPAN_DEV_PR_FMT ", ackreq default: %s", WPAN_PHY_PR_ARG, - WPAN_DEV_PR_ARG, BOOL_TO_STR(__entry->ackreq)) + WPAN_DEV_PR_ARG, str_true_false(__entry->ackreq)) ); TRACE_EVENT(802154_rdev_trigger_scan,
Replace the custom BOOL_TO_STR() macro with the str_true_false() helper function and remove the macro. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- net/ieee802154/trace.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)