From patchwork Thu Oct 22 15:26:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Bird, Tim" X-Patchwork-Id: 7465471 Return-Path: X-Original-To: patchwork-ltsi-dev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 142719F1C3 for ; Thu, 22 Oct 2015 15:26:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 43B5620981 for ; Thu, 22 Oct 2015 15:26:32 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3443520960 for ; Thu, 22 Oct 2015 15:26:31 +0000 (UTC) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 21D671BB; Thu, 22 Oct 2015 15:26:31 +0000 (UTC) X-Original-To: ltsi-dev@lists.linuxfoundation.org Delivered-To: ltsi-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C8AD71BB for ; Thu, 22 Oct 2015 15:26:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from seldrel01.sonyericsson.com (seldrel01.sonyericsson.com [37.139.156.2]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2D0671A3 for ; Thu, 22 Oct 2015 15:26:28 +0000 (UTC) To: Artemi Ivanov From: Tim Bird Message-ID: <5629001D.20105@sonymobile.com> Date: Thu, 22 Oct 2015 08:26:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org Cc: "ltsi-dev@lists.linuxfoundation.org" Subject: [LTSI-dev] [PATCH] Fix argument handling in bc test X-BeenThere: ltsi-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "A list to discuss patches, development, and other things related to the LTSI project" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ltsi-dev-bounces@lists.linuxfoundation.org Errors-To: ltsi-dev-bounces@lists.linuxfoundation.org X-Virus-Scanned: ClamAV using ClamSMTP The argument handling in bc was incorrect. bc-device.sh takes two parameters but only used the first one ($1). bc-script.sh passed the same parameter to bc-device.sh twice. This fixes the problem. --- This fixes this example script. I tested on a beaglebone black. jta/engine/tests/Benchmark.bc/bc-script.sh | 2 +- jta/engine/tests/Benchmark.bc/bc-script/bc-device.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/jta/engine/tests/Benchmark.bc/bc-script.sh b/jta/engine/tests/Benchmark.bc/bc-script.sh index 42ec545..c170801 100755 --- a/jta/engine/tests/Benchmark.bc/bc-script.sh +++ b/jta/engine/tests/Benchmark.bc/bc-script.sh @@ -13,7 +13,7 @@ function test_deploy { function test_run { assert_define BENCHMARK_BC_EXPR1 assert_define BENCHMARK_BC_EXPR2 - report "cd $JTA_HOME/jta.$TESTDIR; ./bc-device.sh $BENCHMARK_BC_EXPR1 $BENCHMARK_BC_EXPR1" + report "cd $JTA_HOME/jta.$TESTDIR; ./bc-device.sh $BENCHMARK_BC_EXPR1 $BENCHMARK_BC_EXPR2" } . $JTA_ENGINE_PATH/scripts/benchmark.sh diff --git a/jta/engine/tests/Benchmark.bc/bc-script/bc-device.sh b/jta/engine/tests/Benchmark.bc/bc-script/bc-device.sh index 461e651..8223dfe 100755 --- a/jta/engine/tests/Benchmark.bc/bc-script/bc-device.sh +++ b/jta/engine/tests/Benchmark.bc/bc-script/bc-device.sh @@ -1,7 +1,7 @@ #!/bin/bash BC_EXPR1=$1 -BC_EXPR2=$1 +BC_EXPR2=$2 BC1=`echo $BC_EXPR1 | bc` BC2=`echo $BC_EXPR2 | bc`