From patchwork Wed Jan 27 15:09:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Bird, Tim" X-Patchwork-Id: 8134731 Return-Path: X-Original-To: patchwork-ltsi-dev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 32EDDBEEE5 for ; Wed, 27 Jan 2016 15:09:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0158020364 for ; Wed, 27 Jan 2016 15:09:57 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6C6720256 for ; Wed, 27 Jan 2016 15:09:55 +0000 (UTC) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 70263E70; Wed, 27 Jan 2016 15:09:55 +0000 (UTC) X-Original-To: ltsi-dev@lists.linuxfoundation.org Delivered-To: ltsi-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 0E05EE70 for ; Wed, 27 Jan 2016 15:09:54 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from SELDSEGREL01.sonyericsson.com (seldsegrel01.sonyericsson.com [37.139.156.29]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2F6FD13C for ; Wed, 27 Jan 2016 15:09:52 +0000 (UTC) To: "ltsi-dev@lists.linuxfoundation.org" From: Tim Bird Message-ID: <56A8DDB2.6030306@sonymobile.com> Date: Wed, 27 Jan 2016 07:09:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org Cc: Dmitry Cherkasov Subject: [LTSI-dev] [PATCH] jta: Fix template-dev target DISTRIB env variable X-BeenThere: ltsi-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "A list to discuss patches, development, and other things related to the LTSI project" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ltsi-dev-bounces@lists.linuxfoundation.org Errors-To: ltsi-dev-bounces@lists.linuxfoundation.org X-Virus-Scanned: ClamAV using ClamSMTP The current front-end Jenkins configuration for the template-dev board currently uses DISTR instead of DISTRIB as an environment variable to specify the distribution overlay file to use. This caused an error when processing tests for any targets copied from that board, about the missing DISTRIB environment variable. From the console log: +++ abort_job 'DISTRIB is not defined' +++ set +x *** ABORTED *** JTA error reason: DISTRIB is not defined Also, this patch adds a missing newline at the end of config.xml --- (As a side note, this was harder to find and fix than expected, because there's another bug in the JTA system. If you edit a target configuration in the Jenkins interface, it breaks the symlink from /userdata/conf/config.xml to /var/lib/jenkins/config.xml. I'll post a separate bug report on that. But, the gist of it is that after you make a single edit to a target in the Jenkins interface, the changes are not reflected in the host userdata/conf/config.xml file (and vice-versa) from then on.) userdata/conf/config.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/userdata/conf/config.xml b/userdata/conf/config.xml index 423d034..8cde7f5 100644 --- a/userdata/conf/config.xml +++ b/userdata/conf/config.xml @@ -42,7 +42,7 @@ 2 BOARD_OVERLAY boards/template-dev.board - DISTR + DISTRIB distribs/nologger.dist @@ -331,4 +331,4 @@ - \ No newline at end of file +