From patchwork Wed Aug 29 12:17:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Motai.Hirotaka@aj.MitsubishiElectric.co.jp" X-Patchwork-Id: 10580151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 39B2B174A for ; Wed, 29 Aug 2018 12:36:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 288902AF7B for ; Wed, 29 Aug 2018 12:36:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1CCFA2AF89; Wed, 29 Aug 2018 12:36:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9F5652AF84 for ; Wed, 29 Aug 2018 12:36:45 +0000 (UTC) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 94E75CBA; Wed, 29 Aug 2018 12:36:35 +0000 (UTC) X-Original-To: ltsi-dev@lists.linuxfoundation.org Delivered-To: ltsi-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id E51B9CB4 for ; Wed, 29 Aug 2018 12:36:34 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mx05.melco.co.jp (mx05.melco.co.jp [192.218.140.145]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 149A76CE for ; Wed, 29 Aug 2018 12:36:33 +0000 (UTC) Received: from mr05.melco.co.jp (mr05 [133.141.98.165]) by mx05.melco.co.jp (Postfix) with ESMTP id BEB273A2709 for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from mr05.melco.co.jp (unknown [127.0.0.1]) by mr05.imss (Postfix) with ESMTP id 420l4M56lzzRkFD for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from mf04_second.melco.co.jp (unknown [192.168.20.184]) by mr05.melco.co.jp (Postfix) with ESMTP id 420l4M4pslzRkC3 for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from mf04.melco.co.jp (unknown [133.141.98.184]) by mf04_second.melco.co.jp (Postfix) with ESMTP id 420l4M4qzjzRkD2 for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (unknown [23.103.139.149]) by mf04.melco.co.jp (Postfix) with ESMTP id 420l4M4RGdzRkCw for ; Wed, 29 Aug 2018 21:17:23 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mitsubishielectricgroup.onmicrosoft.com; s=selector1-mitsubishielectricgroup-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dX54D8Xh4bbXGVnSdzpBEJCRwDLpWvtAIRWmCiIzNFY=; b=lhVuWK5FUl7qgpDy6hXEEZmpnHRMMlwEkIH/O4eDIHPyp2V0nOoTW/x03ZYy8FGvRqiqmSIinheOKqXKFasTWNof6o8zksczz/MDJ/y8zPceI22ioIa2vFCZDwo+IIwOatU6KIlqPSbJ+P7nOGGsLkU22wpxx5bQs1XIMcePInA= Received: from TY1PR01MB1692.jpnprd01.prod.outlook.com (52.133.160.145) by TY1PR01MB1231.jpnprd01.prod.outlook.com (10.174.226.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 12:17:23 +0000 Received: from TY1PR01MB1692.jpnprd01.prod.outlook.com ([fe80::d04e:e6f6:c782:22fa]) by TY1PR01MB1692.jpnprd01.prod.outlook.com ([fe80::d04e:e6f6:c782:22fa%2]) with mapi id 15.20.1080.015; Wed, 29 Aug 2018 12:17:23 +0000 From: "Motai.Hirotaka@aj.MitsubishiElectric.co.jp" To: "ltsi-dev@lists.linuxfoundation.org" Thread-Topic: [LTSI-dev] [PATCH 01/54] tracing: Remove redundant unread variable ret Thread-Index: AdQ/iLga/DlV5ktqRvuAVkjzoEihxA== Date: Wed, 29 Aug 2018 12:17:03 +0000 Deferred-Delivery: Wed, 29 Aug 2018 12:15:00 +0000 Message-ID: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-melpop: 1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Motai.Hirotaka@aj.MitsubishiElectric.co.jp; x-originating-ip: [153.231.200.201] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TY1PR01MB1231; 6:bHAVNkGhpbacJVTP74CtoJeSfQPsZVC/EnHVp+uxoQQNozqdYrE0vxlkgybYSopf5XNWiD08NS1M4KAx24XHgZz3nfzfi2EATCd9ryUIW6Z4xD4JZ1oLdQ0yFHxrXc1ToD92I6LcNJ1Xm/uP3VmkYbJC3ouJx6nFO8KabTWbiIVW3VSOSi3OMRFEEhsktyxbpp0zXvjxuI43vdsiYj3tNprWdXH4RB1CJU9jY3Ei07NK8u7EsHKe0uPnlsZABPBzmYgQ4b5F/54BtpwGTnPnhA/9724BnxyVH+f+X07m4ztX1VWYvSJoUX9qU7QwGjRJySBjOi7OU7RIZOeXhuSgKqNK3WTsFf8zx/i5u16ZVYhWJ6pQ+gzc94lYUHaVLjftjq8aoblkioJSUZU6B556QcBF5NRiRa8tMlIUP/WV2kULbZhTmfR89STi+E+SdubBPsniwDS/SmfwuvisqFaU9A==; 5:WscRM4Ynbk6dO39VsOy2bpDSjETWZujp6hjQyTUlH9rHPLAtZtKXL9QxGNGkMKlX0SOePm70sjuChtjqX2QEekWBX4FkENrD7vDCG3KRFPz7vVdbSfzi57OP1C4lxmHM2Luhc5RCgb3OGC/gzcRs9UOdHl8m26BF6Z7KXfW8rEM=; 7:8qYm46yjxF6LGvcWxcSkmJeDzSqDOLO8JICP2FYMV7/ZnFm5fFIsKNNXS8jfvZcCamVJkuRjD2tPTnC10p9B01gG9uVT4B0mmBgde0j/9uo2z57Mf5ijZ4vdOtPWTVKr6NwZRGgz2/QTLgmWflc8NmNgoZA4Q17N8LaUMgqfgQvWapHkbd1pxnZy5BI+N9Kn7b/LyerDu5iB2Ab+2IZbc18EksdgiBNfA0sWc5bAaoJ+mWWZvq2fDyYqx6iTQIOk x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2300656f-2dde-4bcd-0c2d-08d60da95ffa x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:TY1PR01MB1231; x-ms-traffictypediagnostic: TY1PR01MB1231: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42068640409301)(198206253151910); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(201708071742011)(7699016); SRVR:TY1PR01MB1231; BCL:0; PCL:0; RULEID:; SRVR:TY1PR01MB1231; x-forefront-prvs: 077929D941 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(396003)(366004)(376002)(346002)(39860400002)(189003)(199004)(478600001)(105586002)(2906002)(14454004)(33656002)(66066001)(966005)(72206003)(6116002)(3846002)(97736004)(2900100001)(2501003)(5250100002)(74482002)(25786009)(7736002)(9686003)(5660300001)(6506007)(26005)(6666003)(6916009)(2351001)(81156014)(106356001)(86362001)(6436002)(6306002)(5640700003)(74316002)(8676002)(1857600001)(81166006)(102836004)(53936002)(7696005)(68736007)(55016002)(305945005)(256004)(14444005)(316002)(186003)(8936002)(486006)(99286004)(476003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR01MB1231; H:TY1PR01MB1692.jpnprd01.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0; received-spf: None (protection.outlook.com: aj.MitsubishiElectric.co.jp does not designate permitted sender hosts) x-microsoft-antispam-message-info: M+Ij4o6/hTJXcpQBpMMnhPllUvb9Rcq6R+SLCr0kjD64lghRlep5hpHhuUdcf31R3MVl6brmWZb46US6Ou9M3Fy1q0sNO1RWh8zY97bd1IaPoTW/vXcx7jsjj0HWkF3tedNTfW3cCzhd7MLug5jRNnf7Kn0RHQ7KQxe4FYmE28CfuHS/CCTXpFJE2E16qREAEusep5NxdZ8kzBjLCCcUxl0yfsfOMUpt8wdtZVTP/9gIEIW8necSQPr/w63KkBklIgGCEco6kBXHMjdIqg2U0hIuhOFcHH+pmWuT+cloYQoeV8iRGA7K/qXUG014wC/rzti6r6ZnmzOGDfypx8r2r4wtxenO35yPpQuIh4/OPqM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: aj.MitsubishiElectric.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 2300656f-2dde-4bcd-0c2d-08d60da95ffa X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2018 12:17:22.6237 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: c5a75b62-4bff-4c96-a720-6621ce9978e5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1231 Subject: [LTSI-dev] [PATCH 01/54] tracing: Remove redundant unread variable ret X-BeenThere: ltsi-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "A list to discuss patches, development, and other things related to the LTSI project" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ltsi-dev-bounces@lists.linuxfoundation.org Errors-To: ltsi-dev-bounces@lists.linuxfoundation.org X-Virus-Scanned: ClamAV using ClamSMTP Integer ret is being assigned but never used and hence it is redundant. Remove it, fixes clang warning: trace_events_hist.c:1077:3: warning: Value stored to 'ret' is never read Link: http://lkml.kernel.org/r/20170823112309.19383-1-colin.king@canonical.com Signed-off-by: Colin Ian King Signed-off-by: Steven Rostedt (VMware) (cherry picked from commit 6e7a2398114a2597a0995f96f44d908741ae5035) Signed-off-by: Hirotaka MOTAI --- kernel/trace/trace_events_hist.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 7eb975a2..121d5685 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1057,31 +1057,29 @@ static int print_entries(struct seq_file *m, return n_entries; } static void hist_trigger_show(struct seq_file *m, struct event_trigger_data *data, int n) { struct hist_trigger_data *hist_data; - int n_entries, ret = 0; + int n_entries; if (n > 0) seq_puts(m, "\n\n"); seq_puts(m, "# event histogram\n#\n# trigger info: "); data->ops->print(m, data->ops, data); seq_puts(m, "#\n\n"); hist_data = data->private_data; n_entries = print_entries(m, hist_data); - if (n_entries < 0) { - ret = n_entries; + if (n_entries < 0) n_entries = 0; - } seq_printf(m, "\nTotals:\n Hits: %llu\n Entries: %u\n Dropped: %llu\n", (u64)atomic64_read(&hist_data->map->hits), n_entries, (u64)atomic64_read(&hist_data->map->drops)); } static int hist_show(struct seq_file *m, void *v) {