Message ID | 155168109883.31333.637949571436251317.stgit@noble.brown (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <lustre-devel-bounces@lists.lustre.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 61A5C1575 for <patchwork-lustre-devel@patchwork.kernel.org>; Mon, 4 Mar 2019 06:35:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DAF2289BC for <patchwork-lustre-devel@patchwork.kernel.org>; Mon, 4 Mar 2019 06:35:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 41F9F29D79; Mon, 4 Mar 2019 06:35:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from pdx1-mailman02.dreamhost.com (pdx1-mailman02.dreamhost.com [64.90.62.194]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0653E289BC for <patchwork-lustre-devel@patchwork.kernel.org>; Mon, 4 Mar 2019 06:35:35 +0000 (UTC) Received: from pdx1-mailman02.dreamhost.com (localhost [IPv6:::1]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id 8F52E682925; Sun, 3 Mar 2019 22:35:34 -0800 (PST) X-Original-To: lustre-devel@lists.lustre.org Delivered-To: lustre-devel-lustre.org@pdx1-mailman02.dreamhost.com Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id C0154682930 for <lustre-devel@lists.lustre.org>; Sun, 3 Mar 2019 22:35:32 -0800 (PST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C483EAC9C; Mon, 4 Mar 2019 06:35:31 +0000 (UTC) From: NeilBrown <neilb@suse.com> To: Andreas Dilger <adilger@whamcloud.com>, James Simmons <jsimmons@infradead.org>, Oleg Drokin <green@whamcloud.com> Date: Mon, 04 Mar 2019 17:31:38 +1100 Message-ID: <155168109883.31333.637949571436251317.stgit@noble.brown> In-Reply-To: <155168107971.31333.14345309795939467246.stgit@noble.brown> References: <155168107971.31333.14345309795939467246.stgit@noble.brown> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Subject: [lustre-devel] [PATCH 21/28] lustre: vvp_dev; increment *pos in .next X-BeenThere: lustre-devel@lists.lustre.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "For discussing Lustre software development." <lustre-devel-lustre.org> List-Unsubscribe: <http://lists.lustre.org/options.cgi/lustre-devel-lustre.org>, <mailto:lustre-devel-request@lists.lustre.org?subject=unsubscribe> List-Archive: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/> List-Post: <mailto:lustre-devel@lists.lustre.org> List-Help: <mailto:lustre-devel-request@lists.lustre.org?subject=help> List-Subscribe: <http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org>, <mailto:lustre-devel-request@lists.lustre.org?subject=subscribe> Cc: Lustre Development List <lustre-devel@lists.lustre.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: lustre-devel-bounces@lists.lustre.org Sender: "lustre-devel" <lustre-devel-bounces@lists.lustre.org> X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
More lustre patches...
|
expand
|
diff --git a/drivers/staging/lustre/lustre/llite/vvp_dev.c b/drivers/staging/lustre/lustre/llite/vvp_dev.c index c10ca6e7c606..568943dcb3b4 100644 --- a/drivers/staging/lustre/lustre/llite/vvp_dev.c +++ b/drivers/staging/lustre/lustre/llite/vvp_dev.c @@ -564,7 +564,7 @@ static void *vvp_pgcache_next(struct seq_file *f, void *v, loff_t *pos) struct vvp_seq_private *priv = f->private; WARN_ON(*pos != priv->vsp_prev_pos); - + *pos += 1; priv->vsp_prev_pos = *pos; return vvp_pgcache_next_page(priv); }
As described in Commit 78bb03e221c4 ("lustre: llite: change how "dump_page_cache" walks a hash table") The .next function should increment *pos. For some reason it didn't, and this can trigger the warning in that function. Signed-off-by: NeilBrown <neilb@suse.com> --- drivers/staging/lustre/lustre/llite/vvp_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)