From patchwork Thu Feb 27 21:11:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Simmons X-Patchwork-Id: 11410129 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 690B9138D for ; Thu, 27 Feb 2020 21:30:59 +0000 (UTC) Received: from pdx1-mailman02.dreamhost.com (pdx1-mailman02.dreamhost.com [64.90.62.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51B2120801 for ; Thu, 27 Feb 2020 21:30:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51B2120801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lustre-devel-bounces@lists.lustre.org Received: from pdx1-mailman02.dreamhost.com (localhost [IPv6:::1]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id 053B534973C; Thu, 27 Feb 2020 13:26:19 -0800 (PST) X-Original-To: lustre-devel@lists.lustre.org Delivered-To: lustre-devel-lustre.org@pdx1-mailman02.dreamhost.com Received: from smtp3.ccs.ornl.gov (smtp3.ccs.ornl.gov [160.91.203.39]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id D034021FAF1 for ; Thu, 27 Feb 2020 13:19:21 -0800 (PST) Received: from star.ccs.ornl.gov (star.ccs.ornl.gov [160.91.202.134]) by smtp3.ccs.ornl.gov (Postfix) with ESMTP id BCF1A2ADF; Thu, 27 Feb 2020 16:18:15 -0500 (EST) Received: by star.ccs.ornl.gov (Postfix, from userid 2004) id B9EBF468; Thu, 27 Feb 2020 16:18:15 -0500 (EST) From: James Simmons To: Andreas Dilger , Oleg Drokin , NeilBrown Date: Thu, 27 Feb 2020 16:11:16 -0500 Message-Id: <1582838290-17243-209-git-send-email-jsimmons@infradead.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1582838290-17243-1-git-send-email-jsimmons@infradead.org> References: <1582838290-17243-1-git-send-email-jsimmons@infradead.org> Subject: [lustre-devel] [PATCH 208/622] lustre: llite: enable flock mount option by default X-BeenThere: lustre-devel@lists.lustre.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "For discussing Lustre software development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lustre Development List MIME-Version: 1.0 Errors-To: lustre-devel-bounces@lists.lustre.org Sender: "lustre-devel" From: Andreas Dilger The "flock" mount option has been optional for many years, initially because of potential stability issues, and also to provide a choice for administrators to select between "flock" and "localflock" options. However, from the large number of problems that users report when trying to use applications that depend on this feature (typically databases and other cloud stacks) that disabling flock by default causes more problems than it solves. Enable the "flock" (distributed coherent userspace locking) feature by default. If applications do not need this functionality, then it will not affect them. If applications *do* need this functionality, they will get it. If administrators really know what they are doing, then they can use the "localflock" feature to enable client-local flock functionality, possibly only on select nodes that need this. Users wanting to disable this functionality should mount with the existing "-o noflock" mount option. If clients are already using "-o {flock|localflock|noflock}" then their existing options will be handled appropriately. WC-bug-id: https://jira.whamcloud.com/browse/LU-10885 Lustre-commit: 3613af3e15cb ("LU-10885 llite: enable flock mount option by default") Signed-off-by: Andreas Dilger Reviewed-on: https://review.whamcloud.com/32091 Reviewed-by: Patrick Farrell Reviewed-by: Ben Evans Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- fs/lustre/llite/llite_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/lustre/llite/llite_lib.c b/fs/lustre/llite/llite_lib.c index 4797ee9..84fc54d 100644 --- a/fs/lustre/llite/llite_lib.c +++ b/fs/lustre/llite/llite_lib.c @@ -104,7 +104,7 @@ static struct ll_sb_info *ll_init_sbi(void) sbi->ll_flags |= LL_SBI_VERBOSE; sbi->ll_flags |= LL_SBI_CHECKSUM; - + sbi->ll_flags |= LL_SBI_FLOCK; sbi->ll_flags |= LL_SBI_LRU_RESIZE; sbi->ll_flags |= LL_SBI_LAZYSTATFS;