From patchwork Thu Feb 27 21:15:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Simmons X-Patchwork-Id: 11410425 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB77B138D for ; Thu, 27 Feb 2020 21:38:06 +0000 (UTC) Received: from pdx1-mailman02.dreamhost.com (pdx1-mailman02.dreamhost.com [64.90.62.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3BAD24690 for ; Thu, 27 Feb 2020 21:38:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3BAD24690 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lustre-devel-bounces@lists.lustre.org Received: from pdx1-mailman02.dreamhost.com (localhost [IPv6:::1]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id 9144A34A34C; Thu, 27 Feb 2020 13:31:14 -0800 (PST) X-Original-To: lustre-devel@lists.lustre.org Delivered-To: lustre-devel-lustre.org@pdx1-mailman02.dreamhost.com Received: from smtp3.ccs.ornl.gov (smtp3.ccs.ornl.gov [160.91.203.39]) by pdx1-mailman02.dreamhost.com (Postfix) with ESMTP id 6340021F7B2 for ; Thu, 27 Feb 2020 13:20:36 -0800 (PST) Received: from star.ccs.ornl.gov (star.ccs.ornl.gov [160.91.202.134]) by smtp3.ccs.ornl.gov (Postfix) with ESMTP id 7CB718F33; Thu, 27 Feb 2020 16:18:18 -0500 (EST) Received: by star.ccs.ornl.gov (Postfix, from userid 2004) id 7B9A246C; Thu, 27 Feb 2020 16:18:18 -0500 (EST) From: James Simmons To: Andreas Dilger , Oleg Drokin , NeilBrown Date: Thu, 27 Feb 2020 16:15:11 -0500 Message-Id: <1582838290-17243-444-git-send-email-jsimmons@infradead.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1582838290-17243-1-git-send-email-jsimmons@infradead.org> References: <1582838290-17243-1-git-send-email-jsimmons@infradead.org> Subject: [lustre-devel] [PATCH 443/622] lnet: Fix style issues for selftest/rpc.c X-BeenThere: lustre-devel@lists.lustre.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "For discussing Lustre software development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lustre Development List MIME-Version: 1.0 Errors-To: lustre-devel-bounces@lists.lustre.org Sender: "lustre-devel" From: Shaun Tancheff This patch fixes issues reported by checkpatch for the file selftest/rpc.c. Linux 5.3 enforces the use of 'fallthrough' which is also suggested by checkpatch Cray-bug-id: LUS-7690 WC-bug-id: https://jira.whamcloud.com/browse/LU-12635 Lustre-commit: 4bfe21d09c39 ("LU-12635 lnet: Fix style issues for selftest/rpc.c") Signed-off-by: Shaun Tancheff Reviewed-on: https://review.whamcloud.com/35800 Reviewed-by: Petros Koutoupis Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- net/lnet/selftest/rpc.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/net/lnet/selftest/rpc.c b/net/lnet/selftest/rpc.c index a5941e4..4645f04 100644 --- a/net/lnet/selftest/rpc.c +++ b/net/lnet/selftest/rpc.c @@ -141,7 +141,8 @@ struct srpc_bulk * struct page *pg; int nob; - pg = alloc_pages_node(cfs_cpt_spread_node(lnet_cpt_table(), cpt), + pg = alloc_pages_node(cfs_cpt_spread_node(lnet_cpt_table(), + cpt), GFP_KERNEL, 0); if (!pg) { CERROR("Can't allocate page %d of %d\n", i, bulk_npg); @@ -386,7 +387,8 @@ struct srpc_bulk * return -ENOMEM; } - CDEBUG(D_NET, "Posted passive RDMA: peer %s, portal %d, matchbits %#llx\n", + CDEBUG(D_NET, + "Posted passive RDMA: peer %s, portal %d, matchbits %#llx\n", libcfs_id2str(peer), portal, matchbits); return 0; } @@ -440,7 +442,8 @@ struct srpc_bulk * rc = LNetMDUnlink(*mdh); LASSERT(!rc); } else { - CDEBUG(D_NET, "Posted active RDMA: peer %s, portal %u, matchbits %#llx\n", + CDEBUG(D_NET, + "Posted active RDMA: peer %s, portal %u, matchbits %#llx\n", libcfs_id2str(peer), portal, matchbits); } return 0; @@ -515,7 +518,8 @@ struct srpc_bulk * void srpc_add_buffer(struct swi_workitem *wi) { - struct srpc_service_cd *scd = container_of(wi, struct srpc_service_cd, scd_buf_wi); + struct srpc_service_cd *scd = container_of(wi, struct srpc_service_cd, + scd_buf_wi); struct srpc_buffer *buf; int rc = 0; @@ -662,7 +666,8 @@ struct srpc_bulk * spin_lock(&scd->scd_lock); if (scd->scd_buf_nposted > 0) { - CDEBUG(D_NET, "waiting for %d posted buffers to unlink\n", + CDEBUG(D_NET, + "waiting for %d posted buffers to unlink\n", scd->scd_buf_nposted); spin_unlock(&scd->scd_lock); return 0; @@ -960,7 +965,8 @@ struct srpc_bulk * void srpc_handle_rpc(struct swi_workitem *wi) { - struct srpc_server_rpc *rpc = container_of(wi, struct srpc_server_rpc, srpc_wi); + struct srpc_server_rpc *rpc = container_of(wi, struct srpc_server_rpc, + srpc_wi); struct srpc_service_cd *scd = rpc->srpc_scd; struct srpc_service *sv = scd->scd_svc; struct srpc_event *ev = &rpc->srpc_ev; @@ -1398,7 +1404,9 @@ struct srpc_client_rpc * return rc; } -/* when in kernel always called with lnet_net_lock() held, and in thread context */ +/* when in kernel always called with lnet_net_lock() held, + * and in thread context + */ static void srpc_lnet_ev_handler(struct lnet_event *ev) { @@ -1451,7 +1459,8 @@ struct srpc_client_rpc * rpcev, crpc, &crpc->crpc_reqstev, &crpc->crpc_replyev, &crpc->crpc_bulkev); CERROR("Bad event: status %d, type %d, lnet %d\n", - rpcev->ev_status, rpcev->ev_type, rpcev->ev_lnet); + rpcev->ev_status, rpcev->ev_type, + rpcev->ev_lnet); LBUG(); }