From patchwork Sun Sep 18 05:22:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Simmons X-Patchwork-Id: 12979327 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from pdx1-mailman-customer002.dreamhost.com (listserver-buz.dreamhost.com [69.163.136.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EBBCC6FA8B for ; Sun, 18 Sep 2022 05:23:07 +0000 (UTC) Received: from pdx1-mailman-customer002.dreamhost.com (localhost [127.0.0.1]) by pdx1-mailman-customer002.dreamhost.com (Postfix) with ESMTP id 4MVbmp6V5Cz1yFg; Sat, 17 Sep 2022 22:23:06 -0700 (PDT) Received: from smtp3.ccs.ornl.gov (smtp3.ccs.ornl.gov [160.91.203.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pdx1-mailman-customer002.dreamhost.com (Postfix) with ESMTPS id 4MVbmC4sPkz1yD9 for ; Sat, 17 Sep 2022 22:22:35 -0700 (PDT) Received: from star.ccs.ornl.gov (star.ccs.ornl.gov [160.91.202.134]) by smtp3.ccs.ornl.gov (Postfix) with ESMTP id 198838F17; Sun, 18 Sep 2022 01:22:17 -0400 (EDT) Received: by star.ccs.ornl.gov (Postfix, from userid 2004) id 17D99E8BA5; Sun, 18 Sep 2022 01:22:17 -0400 (EDT) From: James Simmons To: Andreas Dilger , Oleg Drokin , NeilBrown Date: Sun, 18 Sep 2022 01:22:13 -0400 Message-Id: <1663478534-19917-24-git-send-email-jsimmons@infradead.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1663478534-19917-1-git-send-email-jsimmons@infradead.org> References: <1663478534-19917-1-git-send-email-jsimmons@infradead.org> Subject: [lustre-devel] [PATCH 23/24] lnet: Honor peer timeout of zero X-BeenThere: lustre-devel@lists.lustre.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: "For discussing Lustre software development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Horn , Lustre Development List MIME-Version: 1.0 Errors-To: lustre-devel-bounces@lists.lustre.org Sender: "lustre-devel" From: Chris Horn Zero is a valid value for the peer_timeout parameter (it is supposed to disable the LNet Peer Health feature used on routers), but DLC treats zero as uninitialized and assigns the default peer timeout instead. HPE-bug-id: LUS-11233 WC-bug-id: https://jira.whamcloud.com/browse/LU-16145 Lustre-commit: eee27c88adc39da36 ("LU-16145 lnet: Honor peer timeout of zero") Signed-off-by: Chris Horn Reviewed-on: https://review.whamcloud.com/48489 Reviewed-by: Frank Sehr Reviewed-by: Serguei Smirnov Reviewed-by: Oleg Drokin Signed-off-by: James Simmons --- net/lnet/lnet/api-ni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/lnet/lnet/api-ni.c b/net/lnet/lnet/api-ni.c index 9bf2860..89c7b99 100644 --- a/net/lnet/lnet/api-ni.c +++ b/net/lnet/lnet/api-ni.c @@ -3466,7 +3466,7 @@ static int lnet_add_net_common(struct lnet_net *net, lnet_set_tune_defaults(struct lnet_ioctl_config_lnd_tunables *tun) { if (tun) { - if (!tun->lt_cmn.lct_peer_timeout) + if (tun->lt_cmn.lct_peer_timeout < 0) tun->lt_cmn.lct_peer_timeout = DEFAULT_PEER_TIMEOUT; if (!tun->lt_cmn.lct_peer_tx_credits) tun->lt_cmn.lct_peer_tx_credits = DEFAULT_PEER_CREDITS;