| Message ID | 87y3avc1fp.fsf@notabene.neil.brown.name (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | lustre: lprocfs: fix return value of lprocfs_read_helper | expand |
> This should be 'ret', not zero. I bet that was one of my first patches to the linux lustre client since its a really old patch. Thanks for figuring that out. Reviewed-by: James Simmons <jsimmons@infradead.org> > Fixes: fdedd94509fd ("staging/lustre/lvfs: remove the lvfs layer") > Signed-off-by: NeilBrown <neilb@suse.com> > --- > drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > index dc1d540e05c7..edac88440b41 100644 > --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c > @@ -1509,7 +1509,7 @@ __s64 lprocfs_read_helper(struct lprocfs_counter *lc, > break; > } > > - return 0; > + return ret; > } > EXPORT_SYMBOL(lprocfs_read_helper); > > -- > 2.14.0.rc0.dirty > >
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c index dc1d540e05c7..edac88440b41 100644 --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c @@ -1509,7 +1509,7 @@ __s64 lprocfs_read_helper(struct lprocfs_counter *lc, break; } - return 0; + return ret; } EXPORT_SYMBOL(lprocfs_read_helper);
This should be 'ret', not zero. Fixes: fdedd94509fd ("staging/lustre/lvfs: remove the lvfs layer") Signed-off-by: NeilBrown <neilb@suse.com> --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)