| Message ID | 20250306-net-next-tcp-ulp-diag-net-admin-v1-0-06afdd860fc9@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | tcp: ulp: diag: expose more to non net admin users | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 06 Mar 2025 12:29:26 +0100 you wrote: > Since its introduction in commit 61723b393292 ("tcp: ulp: add functions > to dump ulp-specific information"), the ULP diag info have been exported > only to users with CAP_NET_ADMIN capability. > > Not everything is sensitive, and some info can be exported to all users > in order to ease the debugging from the userspace side without requiring > additional capabilities. > > [...] Here is the summary with links: - [net-next,1/2] tcp: ulp: diag: always print the name if any https://git.kernel.org/netdev/net-next/c/f5afcb9fbb39 - [net-next,2/2] tcp: ulp: diag: more info without CAP_NET_ADMIN https://git.kernel.org/netdev/net-next/c/0d7336f8f06d You are awesome, thank you!
Since its introduction in commit 61723b393292 ("tcp: ulp: add functions to dump ulp-specific information"), the ULP diag info have been exported only to users with CAP_NET_ADMIN capability. Not everything is sensitive, and some info can be exported to all users in order to ease the debugging from the userspace side without requiring additional capabilities. First, the ULP name can be easily exported. Then more depending on each layer: - On kTLS side, it looks like everything can be exported to all users: version, cipher type, tx/rx user config type, plus some flags. - On MPTCP side, everything but the sequence numbers are exported to all non net admin users, similar to TCP. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Matthieu Baerts (NGI0) (2): tcp: ulp: diag: always print the name if any tcp: ulp: diag: more info without CAP_NET_ADMIN include/net/tcp.h | 4 ++-- net/ipv4/tcp_diag.c | 21 ++++++++++----------- net/mptcp/diag.c | 42 ++++++++++++++++++++++++++---------------- net/tls/tls_main.c | 4 ++-- 4 files changed, 40 insertions(+), 31 deletions(-) --- base-commit: f130a0cc1b4ff1ef28a307428d40436032e2b66e change-id: 20250306-net-next-tcp-ulp-diag-net-admin-a1d6d7f9910b Best regards,