Message ID | cover.1729159086.git.tanggeliang@kylinos.cn (mailing list archive) |
---|---|
Headers | show |
Series | fixes for "add mptcp_subflow bpf_iter" v10 | expand |
Hi Geliang, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: Success! ✅ - KVM Validation: debug: Success! ✅ - KVM Validation: btf-normal (only bpftest_all): Script error! ❓ - Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11383143433 Initiator: Patchew Applier Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/a092947680a3 Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=900181 If there are some issues, you can reproduce them using the same environment as the one used by the CI thanks to a docker image, e.g.: $ cd [kernel source code] $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \ --pull always mptcp/mptcp-upstream-virtme-docker:latest \ auto-normal For more details: https://github.com/multipath-tcp/mptcp-upstream-virtme-docker Please note that despite all the efforts that have been already done to have a stable tests suite when executed on a public CI like here, it is possible some reported issues are not due to your modifications. Still, do not hesitate to help us improve that ;-) Cheers, MPTCP GH Action bot Bot operated by Matthieu Baerts (NGI0 Core)
From: Geliang Tang <tanggeliang@kylinos.cn> There's a building error in v10: progs/mptcp_bpf_iters.c:24:8: error: call to undeclared function 'bpf_mptcp_sk'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 24 | msk = bpf_mptcp_sk((struct sock *)sk); | ^ progs/mptcp_bpf_iters.c:24:6: error: incompatible integer to pointer conversion assigning to 'struct mptcp_sock *' from 'int' [-Wint-conversion] 24 | msk = bpf_mptcp_sk((struct sock *)sk); bpf_mptcp_sk() definition is missing. It will be used in patch 4. Depends on: - "add mptcp_subflow bpf_iter" v10 Based-on: <cover.1729063444.git.tanggeliang@kylinos.cn> Geliang Tang (2): Squash to "bpf: Register mptcp common kfunc set" Squash to "selftests/bpf: Add mptcp_subflow bpf_iter test prog" net/mptcp/bpf.c | 6 ++++++ tools/testing/selftests/bpf/progs/mptcp_bpf.h | 1 + 2 files changed, 7 insertions(+)