| Message ID | cover.1739788598.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | use bpf_iter in bpf schedulers | expand |
On Mon, 17 Feb 2025, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > v15: > - patch 7, add the declaration of bpf_mptcp_subflow_tcp_sock > > Depends on: > - Squash to "Add mptcp_subflow bpf_iter support", v3 > > Based-on: <cover.1739787744.git.tanggeliang@kylinos.cn> Hi Geliang - I don't have any changes to suggest to this series, so I'll add my reviewed tag even though this can't be applied to the export branch yet (until the bpf_iter series is updated): Reviewed-by: Mat Martineau <martineau@kernel.org> > > v14: > - patch 1, keep mptcp_sched_data_set_contexts() helper for future use. > - patch 2, use "sk = sk__ign" in bpf_mptcp_subflow_ctx() and > bpf_sk_stream_memory_free(). > - patch 8, drop "subflows" from struct mptcp_sched_data too. > > v13: > - use '__ign' suffix to ignore the argument type checks of > bpf_mptcp_subflow_ctx() and bpf_sk_stream_memory_free(), > instead of adding a new helper bpf_mptcp_send_info_to_ssk(). > - use 'bpf_for_each(mptcp_subflow, subflow, (struct sock *)msk)' instead > of using 'bpf_for_each(mptcp_subflow, subflow, msk)'. > - keep struct mptcp_sched_data for future use. > > v12: > - drop struct mptcp_sched_data. > - rebased on "split get_subflow interface into two" v2. > > v11: > If another squash-to patchset (Squash to "Add mptcp_subflow bpf_iter > support") under review is merged before this set, v10 will fail to run. > v11 fixes this issue and can run regardless of whether it is merged > before or after the squash-to patchset. > > Compared with v10, only patches 3, 5, and 8 have been modified: > - use mptcp_subflow_tcp_sock instead of bpf_mptcp_subflow_tcp_sock in > patch 3 and patch 5. > - drop bpf_mptcp_sched_kfunc_set, use bpf_mptcp_common_kfunc_set instead > in patch 8. > > v10: > - drop mptcp_subflow_set_scheduled() helper and WRITE_ONCE() in BPF. > - add new bpf helper bpf_mptcp_send_info_to_ssk() for burst scheduler. > > v9: > - merge 'Fixes for "use bpf_iter in bpf schedulers" v8' into this set. > - rebased on "add netns helpers" v4 > > v8: > - address Mat's comments in v7. > - move sk_stream_memory_free check inside bpf_for_each() loop. > - implement mptcp_subflow_set_scheduled helper in BPF. > - add cleanup patches into this set again. > > v7: > - move cleanup patches out of this set. > - rebased. > > v6: > - rebased to "add mptcp_subflow bpf_iter" v10 > > v5: > - patch 2, drop mptcp_sock_type and mptcp_subflow_type. > - patch 3, revert "bpf: Export more bpf_burst related functions" > - patch 4, merge "bpf: Export more bpf_burst related functions" into it. > > v4: > - patch 2, a new cleanup for "bpf: Add bpf_mptcp_sched_ops". > - patch 3 should be reverted. > - patch 8, register kfunc_set. > > v3: > - rebased. > - put the "drop has_bytes_sent" squash-to patch into this set. > > v2: > - update bpf_rr and bpf_burst > > With the newly added mptcp_subflow bpf_iter, we can get rid of the > subflows array "contexts" in struct mptcp_sched_data. This set > uses bpf_for_each(mptcp_subflow) helper to update all the bpf > schedules: > > bpf_for_each(mptcp_subflow, subflow, (struct sock *)msk) { > ... ... > mptcp_subflow_set_scheduled(subflow, true); > } > > Geliang Tang (8): > Squash to "mptcp: add sched_data helpers" > Squash to "bpf: Export mptcp packet scheduler helpers" > Squash to "selftests/bpf: Add bpf_first scheduler & test" > Squash to "selftests/bpf: Add bpf_bkup scheduler & test" > Squash to "selftests/bpf: Add bpf_rr scheduler & test" > Squash to "selftests/bpf: Add bpf_red scheduler & test" > Squash to "selftests/bpf: Add bpf_burst scheduler & test" > mptcp: drop subflow contexts in mptcp_sched_data > > include/net/mptcp.h | 4 - > net/mptcp/bpf.c | 50 ++++++------ > net/mptcp/protocol.h | 2 - > net/mptcp/sched.c | 15 ---- > tools/testing/selftests/bpf/progs/mptcp_bpf.h | 5 +- > .../selftests/bpf/progs/mptcp_bpf_bkup.c | 16 +--- > .../selftests/bpf/progs/mptcp_bpf_burst.c | 78 +++++++------------ > .../selftests/bpf/progs/mptcp_bpf_first.c | 8 +- > .../selftests/bpf/progs/mptcp_bpf_red.c | 8 +- > .../selftests/bpf/progs/mptcp_bpf_rr.c | 31 ++++---- > 10 files changed, 83 insertions(+), 134 deletions(-) > > -- > 2.43.0 > > >
From: Geliang Tang <tanggeliang@kylinos.cn> v15: - patch 7, add the declaration of bpf_mptcp_subflow_tcp_sock Depends on: - Squash to "Add mptcp_subflow bpf_iter support", v3 Based-on: <cover.1739787744.git.tanggeliang@kylinos.cn> v14: - patch 1, keep mptcp_sched_data_set_contexts() helper for future use. - patch 2, use "sk = sk__ign" in bpf_mptcp_subflow_ctx() and bpf_sk_stream_memory_free(). - patch 8, drop "subflows" from struct mptcp_sched_data too. v13: - use '__ign' suffix to ignore the argument type checks of bpf_mptcp_subflow_ctx() and bpf_sk_stream_memory_free(), instead of adding a new helper bpf_mptcp_send_info_to_ssk(). - use 'bpf_for_each(mptcp_subflow, subflow, (struct sock *)msk)' instead of using 'bpf_for_each(mptcp_subflow, subflow, msk)'. - keep struct mptcp_sched_data for future use. v12: - drop struct mptcp_sched_data. - rebased on "split get_subflow interface into two" v2. v11: If another squash-to patchset (Squash to "Add mptcp_subflow bpf_iter support") under review is merged before this set, v10 will fail to run. v11 fixes this issue and can run regardless of whether it is merged before or after the squash-to patchset. Compared with v10, only patches 3, 5, and 8 have been modified: - use mptcp_subflow_tcp_sock instead of bpf_mptcp_subflow_tcp_sock in patch 3 and patch 5. - drop bpf_mptcp_sched_kfunc_set, use bpf_mptcp_common_kfunc_set instead in patch 8. v10: - drop mptcp_subflow_set_scheduled() helper and WRITE_ONCE() in BPF. - add new bpf helper bpf_mptcp_send_info_to_ssk() for burst scheduler. v9: - merge 'Fixes for "use bpf_iter in bpf schedulers" v8' into this set. - rebased on "add netns helpers" v4 v8: - address Mat's comments in v7. - move sk_stream_memory_free check inside bpf_for_each() loop. - implement mptcp_subflow_set_scheduled helper in BPF. - add cleanup patches into this set again. v7: - move cleanup patches out of this set. - rebased. v6: - rebased to "add mptcp_subflow bpf_iter" v10 v5: - patch 2, drop mptcp_sock_type and mptcp_subflow_type. - patch 3, revert "bpf: Export more bpf_burst related functions" - patch 4, merge "bpf: Export more bpf_burst related functions" into it. v4: - patch 2, a new cleanup for "bpf: Add bpf_mptcp_sched_ops". - patch 3 should be reverted. - patch 8, register kfunc_set. v3: - rebased. - put the "drop has_bytes_sent" squash-to patch into this set. v2: - update bpf_rr and bpf_burst With the newly added mptcp_subflow bpf_iter, we can get rid of the subflows array "contexts" in struct mptcp_sched_data. This set uses bpf_for_each(mptcp_subflow) helper to update all the bpf schedules: bpf_for_each(mptcp_subflow, subflow, (struct sock *)msk) { ... ... mptcp_subflow_set_scheduled(subflow, true); } Geliang Tang (8): Squash to "mptcp: add sched_data helpers" Squash to "bpf: Export mptcp packet scheduler helpers" Squash to "selftests/bpf: Add bpf_first scheduler & test" Squash to "selftests/bpf: Add bpf_bkup scheduler & test" Squash to "selftests/bpf: Add bpf_rr scheduler & test" Squash to "selftests/bpf: Add bpf_red scheduler & test" Squash to "selftests/bpf: Add bpf_burst scheduler & test" mptcp: drop subflow contexts in mptcp_sched_data include/net/mptcp.h | 4 - net/mptcp/bpf.c | 50 ++++++------ net/mptcp/protocol.h | 2 - net/mptcp/sched.c | 15 ---- tools/testing/selftests/bpf/progs/mptcp_bpf.h | 5 +- .../selftests/bpf/progs/mptcp_bpf_bkup.c | 16 +--- .../selftests/bpf/progs/mptcp_bpf_burst.c | 78 +++++++------------ .../selftests/bpf/progs/mptcp_bpf_first.c | 8 +- .../selftests/bpf/progs/mptcp_bpf_red.c | 8 +- .../selftests/bpf/progs/mptcp_bpf_rr.c | 31 ++++---- 10 files changed, 83 insertions(+), 134 deletions(-)