[mptcp-next,v8,00/12] BPF path manager, part 5

Message

Geliang Tang March 4, 2025, 11:40 a.m. UTC

From: Geliang Tang <[e-mail]>

v8:
 - address Matt's comments in v7.

v7:
 - addresss Matt's comments in v6 [1].
 - drop "type" from struct mptcp_pm_ops as Matt suggested.
 - map "pm_type" to new sysctl as Matt suggested.

Depends on:
 - mptcp: pm: code reorganisation, v2

Based-on: <[e-mail]>

[1]
https://patchwork.kernel.org/project/mptcp/cover/[e-mail]/

v6:
 - add "name" in struct mptcp_pm_ops.
 - add some "sysctl" patches.
 - drop "struct mptcp_pm_param".
 - drop "pm_type" in mptcp_pm_data.

v5:
 - use "struct mptcp_pm_param *param" as unified parameters for all
   interfaces.
 - register in-kernel mptcp_pm_ops too.
 - only implement two interfaces "get_local_id" and "get_priority" in
   this set.

v4:
 - include a new patch "define BPF path manager type".

 - add new interfaces:
	created established closed
	listerner_created listener_closed

 - rename interfaces as:
	address_announced address_removed
	subflow_established subflow_closed
	get_priority set_priority

 - rename functions as:
	mptcp_pm_validate
	mptcp_pm_register
	mptcp_pm_unregister
	mptcp_pm_initialize
	mptcp_pm_release

v3:
 - rename the 2nd parameter of get_local_id() from 'local' to 'skc'.
 - keep the 'msk_sport' check in mptcp_userspace_pm_get_local_id().
 - return 'err' instead of '0' in userspace_pm_subflow_create().
 - drop 'ret' variable inmptcp_pm_data_reset().
 - fix typos in commit log.

v2:
 - update get_local_id interface in patch 2.

get_addr() and dump_addr() interfaces of BPF userspace pm are dropped
as Matt suggested.

In order to implement BPF path manager, it's necessary to unify the
interfaces of the path manager. This set contains some cleanups and
refactoring to unify the interfaces in kernel space. Finally, define
a struct mptcp_pm_ops for a path manager.

Geliang Tang (12):
  mptcp: pm: define struct mptcp_pm_ops
  mptcp: sysctl: new sysctl to set path manager by name
  mptcp: sysctl: map pm_type to path_manager
  mptcp: sysctl: map path_manager to pm_type
  mptcp: sysctl: add available_path_managers
  mptcp: pm: in-kernel: register mptcp_pm_kernel
  mptcp: pm: userspace: register mptcp_pm_userspace
  mptcp: pm: initialize and release mptcp_pm_ops
  mptcp: pm: add get_local_id() interface
  mptcp: pm: add get_priority() interface
  selftests: mptcp: add pm_type mapping tests
  selftests: mptcp: add path_manager sysctl test

 Documentation/networking/mptcp-sysctl.rst     |  23 +++
 include/net/mptcp.h                           |  19 +++
 net/mptcp/ctrl.c                              | 112 +++++++++++++-
 net/mptcp/pm.c                                | 145 ++++++++++++++----
 net/mptcp/pm_kernel.c                         |  35 ++++-
 net/mptcp/pm_userspace.c                      |  36 ++++-
 net/mptcp/protocol.h                          |  18 ++-
 .../testing/selftests/net/mptcp/mptcp_join.sh |  49 +++++-
 8 files changed, 393 insertions(+), 44 deletions(-)

Comments

Matthieu Baerts (NGI0) March 5, 2025, 11:41 a.m. UTC | #1

Hi Geliang,

On 04/03/2025 12:40, Geliang Tang wrote:
> From: Geliang Tang <[e-mail]>
> 
> v8:
>  - address Matt's comments in v7.

Thank you for the new version 8.

Please next time add an individual changelog, it is hard to follow the
modifications between versions without that.

I have some comments, please see my individual reviews.

> v7:
>  - addresss Matt's comments in v6 [1].
>  - drop "type" from struct mptcp_pm_ops as Matt suggested.
>  - map "pm_type" to new sysctl as Matt suggested.
> 
> Depends on:
>  - mptcp: pm: code reorganisation, v2
> 
> Based-on: <[e-mail]>

Please drop this line next time, the CI didn't manage to apply and
validate this series because of that.

Cheers,
Matt