| Message ID | 69fc350d5e6b4faeb9cffbbd5d36723e236b2ca2.1623849517.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 94e9d2854eaa1bf620fef12ca8a221604ef3cedb |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [mptcp-next] Squash-to: "selftests: mptcp: turn rp_filter off on each NIC" | expand |
Hi Paolo, On 16/06/2021 15:20, Paolo Abeni wrote: > "$1" is undefined in the setup loop context, $i should be used > instead, otherwise setup (and tests) will fail. > > Signed-off-by: Paolo Abeni <pabeni@redhat.com> Good catch! - 94e9d2854eaa: "squashed" in "selftests: mptcp: turn rp_filter off on each NIC" - 7c34dfc3461b: "Signed-off-by" + "Co-developed-by" - Results: bddebf30244a..2f591d25eeec Builds and tests are now in progress: https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210616T135631 https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210616T135631 Cheers, Matt
diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh index 6b6336d1c39d..fd63ebfe9a2b 100755 --- a/tools/testing/selftests/net/mptcp/simult_flows.sh +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh @@ -60,8 +60,8 @@ setup() for i in "$ns1" "$ns2" "$ns3";do ip netns add $i || exit $ksft_skip ip -net $i link set lo up - ip netns exec $1 sysctl -q net.ipv4.conf.all.rp_filter=0 - ip netns exec $1 sysctl -q net.ipv4.conf.default.rp_filter=0 + ip netns exec $i sysctl -q net.ipv4.conf.all.rp_filter=0 + ip netns exec $i sysctl -q net.ipv4.conf.default.rp_filter=0 done ip link add ns1eth1 netns "$ns1" type veth peer name ns2eth1 netns "$ns2"
"$1" is undefined in the setup loop context, $i should be used instead, otherwise setup (and tests) will fail. Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- tools/testing/selftests/net/mptcp/simult_flows.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)