| Message ID | 0d20e25a-640c-72c1-2dcb-7a53a05e3132@sberdevices.ru (mailing list archive) |
|---|---|
| Headers | show |
| Series | vsock: return errors other than -ENOMEM to socket | expand |
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Mon, 3 Apr 2023 14:23:00 +0300 you wrote: > Hello, > > this patchset removes behaviour, where error code returned from any > transport was always switched to ENOMEM. This works in the same way as > patch from Bobby Eshleman: > commit c43170b7e157 ("vsock: return errors other than -ENOMEM to socket"), > but for receive calls. VMCI transport is also updated (both tx and rx > SOCK_STREAM callbacks), because it returns VMCI specific error code to > af_vsock.c (like VMCI_ERROR_*). Tx path is already merged to net, so it > was excluded from patchset in v4. At the same time, virtio and Hyper-V > transports are using general error codes, so there is no need to update > them. > > [...] Here is the summary with links: - [net-next,v4,1/3] vsock/vmci: convert VMCI error code to -ENOMEM on receive https://git.kernel.org/netdev/net-next/c/f59f3006ca7b - [net-next,v4,2/3] vsock: return errors other than -ENOMEM to socket https://git.kernel.org/netdev/net-next/c/02ab696febab - [net-next,v4,3/3] vsock/test: update expected return values https://git.kernel.org/netdev/net-next/c/b5d54eb5899a You are awesome, thank you!
Hello, this patchset removes behaviour, where error code returned from any transport was always switched to ENOMEM. This works in the same way as patch from Bobby Eshleman: commit c43170b7e157 ("vsock: return errors other than -ENOMEM to socket"), but for receive calls. VMCI transport is also updated (both tx and rx SOCK_STREAM callbacks), because it returns VMCI specific error code to af_vsock.c (like VMCI_ERROR_*). Tx path is already merged to net, so it was excluded from patchset in v4. At the same time, virtio and Hyper-V transports are using general error codes, so there is no need to update them. vsock_test suite is also updated. Link to v1: https://lore.kernel.org/netdev/97f19214-ba04-c47e-7486-72e8aa16c690@sberdevices.ru/ Link to v2: https://lore.kernel.org/netdev/60abc0da-0412-6e25-eeb0-8e32e3ec21e7@sberdevices.ru/ Link to v3: https://lore.kernel.org/netdev/dead4842-333a-015e-028b-302151336ff9@sberdevices.ru/ Changelog: v1 -> v2: - Add patch for VMCI as Vishnu Dasa suggested. v2 -> v3: - Change type of 'err' var in VMCI patches from 'int' to 'ssize_t'. - Split VMCI patch to two patches: for send and for receive cases. - Reorder patches: move VMCI before af_vsock.c. v3 -> v4: - Exclude VMCI patch for send from patchset (merged to 'net'). - Update commit message of VMCI patch for receive. Arseniy Krasnov (3): vsock/vmci: convert VMCI error code to -ENOMEM on receive vsock: return errors other than -ENOMEM to socket vsock/test: update expected return values net/vmw_vsock/af_vsock.c | 4 ++-- net/vmw_vsock/vmci_transport.c | 11 +++++++++-- tools/testing/vsock/vsock_test.c | 4 ++-- 3 files changed, 13 insertions(+), 6 deletions(-)