mbox series

[v1,0/2] Fix implicit sign conversions in handshake upcall

Message ID 169515283988.5349.4586265020008671093.stgit@oracle-102.nfsv4bat.org (mailing list archive)
Headers show
Series Fix implicit sign conversions in handshake upcall | expand

Message

Chuck Lever Sept. 19, 2023, 7:49 p.m. UTC
An internal static analysis tool noticed some implicit sign
conversions for some of the arguments in the handshake upcall
protocol.

---

Chuck Lever (2):
      handshake: Fix sign of socket file descriptor fields
      handshake: Fix sign of key_serial_t fields


 Documentation/netlink/specs/handshake.yaml |  8 ++++----
 net/handshake/genl.c                       |  2 +-
 net/handshake/netlink.c                    |  2 +-
 net/handshake/tlshd.c                      |  6 +++---
 tools/net/ynl/generated/handshake-user.h   | 10 +++++-----
 5 files changed, 14 insertions(+), 14 deletions(-)

--
Chuck Lever

Comments

Paolo Abeni Sept. 21, 2023, 8:59 a.m. UTC | #1
Hi,

On Tue, 2023-09-19 at 15:49 -0400, Chuck Lever wrote:
> An internal static analysis tool noticed some implicit sign
> conversions for some of the arguments in the handshake upcall
> protocol.

This does not apply cleanly to -net nor to -net-next, and the lack of
the target inside the subj is confusing. I guess this is for your devel
tree???

Cheers,

Paolo
Chuck Lever Sept. 21, 2023, 1:02 p.m. UTC | #2
> On Sep 21, 2023, at 4:59 AM, Paolo Abeni <pabeni@redhat.com> wrote:
> 
> Hi,
> 
> On Tue, 2023-09-19 at 15:49 -0400, Chuck Lever wrote:
>> An internal static analysis tool noticed some implicit sign
>> conversions for some of the arguments in the handshake upcall
>> protocol.
> 
> This does not apply cleanly to -net nor to -net-next, and the lack of
> the target inside the subj is confusing. I guess this is for your devel
> tree???

Series as submitted was based on v6.5 because I wasn't expecting
conflicts. I will rebase on net-next and resubmit.


--
Chuck Lever