From patchwork Thu Oct 19 00:06:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nambiar, Amritha" X-Patchwork-Id: 13428132 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1123639861 for ; Wed, 18 Oct 2023 23:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gxVBcEqd" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15BC7FA for ; Wed, 18 Oct 2023 16:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697673009; x=1729209009; h=subject:from:to:cc:date:message-id:mime-version: content-transfer-encoding; bh=62y2fQLtbKrUJOGXk57dPqan/ccA4Z5DQpQloke24k8=; b=gxVBcEqd5EWZCi5ylWVSxjFcLSbT2t9qOSs/U3X0Iu50THqWC6jRTVOt C78audgUBdx0ZY0V30FB0Wc+NCJDG2E8xQOCSVhwy0kfiimkEzkAD63tE AJltpHFLuDS0dXDxn0pxbU0sMW/+0NYeWH8S4dd7ext+qqJIcBSSo7qEt JOuo167TS+wsY+lY1DjNQmzKvVrecKEJ4/BoaHmNmf3ALxSiKLgdbbO6p WgmWIBeytnkF6/awwWop6LjLBzJuHq15Ol7OKAvwLdfRQBZi2oxDibElr OLKsGNCfL5g6de/CVs1NCjWx1GiwHkD2O7KbLJ0pUof4N8aU/YD84CLCy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="452610858" X-IronPort-AV: E=Sophos;i="6.03,236,1694761200"; d="scan'208";a="452610858" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 16:50:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="1004008876" X-IronPort-AV: E=Sophos;i="6.03,236,1694761200"; d="scan'208";a="1004008876" Received: from anambiarhost.jf.intel.com ([10.166.29.163]) by fmsmga006.fm.intel.com with ESMTP; 18 Oct 2023 16:50:08 -0700 Subject: [net-next PATCH v5 00/10] Introduce queue and NAPI support in netdev-genl (Was: Introduce NAPI queues support) From: Amritha Nambiar To: netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com Cc: sridhar.samudrala@intel.com, amritha.nambiar@intel.com Date: Wed, 18 Oct 2023 17:06:01 -0700 Message-ID: <169767295948.6692.18077536155633460138.stgit@anambiarhost.jf.intel.com> User-Agent: StGit/unknown-version Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Add the capability to export the following via netdev-genl interface: - queue information supported by the device - NAPI information supported by the device Introduce support for associating queue and NAPI instance. Extend the netdev_genl generic netlink family for netdev with queue and NAPI data. The queue parameters exposed are: - queue index - queue type - ifindex - NAPI id associated with the queue Additional rx and tx queue parameters can be exposed in follow up patches by stashing them in netdev queue structures. XDP queue type can also be supported in future. The NAPI fields exposed are: - NAPI id - NAPI device ifindex - Interrupt number associated with the NAPI instance - PID for the NAPI thread This series only supports 'get' ability for retrieving certain queue and NAPI attributes. The 'set' ability for configuring queue and associated NAPI instance via netdev-genl will be submitted as a separate patch series. Previous discussion at: https://lore.kernel.org/netdev/c8476530638a5f4381d64db0e024ed49c2db3b02.camel@gmail.com/T/#m00999652a8b4731fbdb7bf698d2e3666c65a60e7 $ ./cli.py --spec netdev.yaml --do queue-get --json='{"ifindex": 12, "queue-id": 0, "queue-type": 0}' {'ifindex': 12, 'napi-id': 593, 'queue-id': 0, 'queue-type': 'rx'} $ ./cli.py --spec netdev.yaml --do queue-get --json='{"ifindex": 12, "queue-id": 0, "queue-type": 1}' {'ifindex': 12, 'napi-id': 593, 'queue-id': 0, 'queue-type': 'tx'} $ ./cli.py --spec netdev.yaml --dump queue-get --json='{"ifindex": 12}' [{'ifindex': 12, 'napi-id': 593, 'queue-id': 0, 'queue-type': 'rx'}, {'ifindex': 12, 'napi-id': 594, 'queue-id': 1, 'queue-type': 'rx'}, {'ifindex': 12, 'napi-id': 595, 'queue-id': 2, 'queue-type': 'rx'}, {'ifindex': 12, 'napi-id': 596, 'queue-id': 3, 'queue-type': 'rx'}, {'ifindex': 12, 'napi-id': 593, 'queue-id': 0, 'queue-type': 'tx'}, {'ifindex': 12, 'napi-id': 594, 'queue-id': 1, 'queue-type': 'tx'}, {'ifindex': 12, 'napi-id': 595, 'queue-id': 2, 'queue-type': 'tx'}, {'ifindex': 12, 'napi-id': 596, 'queue-id': 3, 'queue-type': 'tx'}] $ ./cli.py --spec netdev.yaml --do napi-get --json='{"napi-id": 593}' {'ifindex': 12, 'irq': 291, 'napi-id': 593, 'pid': 3817} $ ./cli.py --spec netdev.yaml --dump napi-get --json='{"ifindex": 12}' [{'ifindex': 12, 'irq': 294, 'napi-id': 596, 'pid': 3814}, {'ifindex': 12, 'irq': 293, 'napi-id': 595, 'pid': 3815}, {'ifindex': 12, 'irq': 292, 'napi-id': 594, 'pid': 3816}, {'ifindex': 12, 'irq': 291, 'napi-id': 593, 'pid': 3817}] v4 -> v5 * Removed tx_maxrate in queue atrributes * Added lock protection for queue->napi * Addressed other review comments v3 -> v4 Minor nits, changed function name, used list_for_each_entry in place of _rcu v2 -> v3 * Implemented queue as separate netlink object with support for exposing per-queue paramters * Removed queue-list associations with NAPI * Addressed other review feedback WRT tracking list iterations v1 -> v2 * Removed multi-attr nest for NAPI object * Added support for flat/individual NAPI objects * Changed 'do' command to take napi-id as argument * Supported filtered 'dump' (dump with ifindex for a netdev and dump for all netdevs) RFC -> v1 * Changed to separate 'napi_get' command * Added support to expose interrupt and PID for the NAPI * Used list of netdev queue structs * Split patches further and fixed code style and errors --- Amritha Nambiar (10): netdev-genl: spec: Extend netdev netlink spec in YAML for queue net: Add queue and napi association ice: Add support in the driver for associating queue with napi netdev-genl: Add netlink framework functions for queue netdev-genl: spec: Extend netdev netlink spec in YAML for NAPI netdev-genl: Add netlink framework functions for napi netdev-genl: spec: Add irq in netdev netlink YAML spec net: Add NAPI IRQ support netdev-genl: spec: Add PID in netdev netlink YAML spec netdev-genl: Add PID for the NAPI thread Documentation/netlink/specs/netdev.yaml | 88 ++++++++ drivers/net/ethernet/intel/ice/ice_lib.c | 63 ++++++ drivers/net/ethernet/intel/ice/ice_lib.h | 4 drivers/net/ethernet/intel/ice/ice_main.c | 4 include/linux/netdevice.h | 17 ++ include/net/netdev_rx_queue.h | 4 include/uapi/linux/netdev.h | 27 ++ net/core/dev.c | 49 ++++ net/core/dev.h | 2 net/core/netdev-genl-gen.c | 50 +++++ net/core/netdev-genl-gen.h | 5 net/core/netdev-genl.c | 320 +++++++++++++++++++++++++++++ tools/include/uapi/linux/netdev.h | 27 ++ tools/net/ynl/generated/netdev-user.c | 289 ++++++++++++++++++++++++++ tools/net/ynl/generated/netdev-user.h | 179 ++++++++++++++++ 15 files changed, 1124 insertions(+), 4 deletions(-) --