From patchwork Fri Oct 9 14:35:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Henrik Bjoernlund X-Patchwork-Id: 11826145 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3DAC433E7 for ; Fri, 9 Oct 2020 14:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E39C22276 for ; Fri, 9 Oct 2020 14:38:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="2o9R2ctD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388844AbgJIOhw (ORCPT ); Fri, 9 Oct 2020 10:37:52 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:51452 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733112AbgJIOhu (ORCPT ); Fri, 9 Oct 2020 10:37:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1602254269; x=1633790269; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8bDmiyTkvx37wDFtGUa7I31tickv4SjHCtinc1WW3qQ=; b=2o9R2ctDQr3qTPR/SwLs4znN7CwvcDiLNtdJPwG6z33YWlEvagUbreQB 4XG2JlsDUGpq0tIrsLIMKQaOdSjkTDLKWB/qaq+prP5TSNmTjG0GdYjUK hT3vbEXjNNAwpb3vonJUhIRL/VxCiaVkzKlyW0iada4UDtm/y5KbwhTmR EZxbjODeN79bjiU2/hzi7Bmm9QX7J9JFm3n5RhWsc4dytLX+mr/nZ7Hn5 oMqx/loTswTQnTENaFYAaWxPZ7niQ/D/nM7fhXp1b/D41QiAENnuuIe4j v0DqAhminUjtpz2Np/XcNoqlqku1GXCEcmgU0V8bRibBNyyygQNBOfXEi Q==; IronPort-SDR: 0rVodOGpszGsyOQS725oAxCUZh31/0lDpPRc+dHh8wLF67CWbKe3deH2xseYuY/hXFO8QkCMWP NLOpMooFMQtXreUclNd+cz0X5C6pmr5WNU1BTQO/eZY3u0y1AaJTvxSQLSFFDDx0vEYJWcWN7I 4laXnBjz2fl7ITEAi+lZ0j4K7r1x4OSQJ8Fr4dowsDhrxMsHfpzfVFMIKSmL9Fjps6f2kO/ZDB l/cSllQNSXmeh08dOwS24gx/CNgIgkdP94uY0fzkaA21619jmovNJUu41Y0Etgd1eFUFxD+Up6 cpM= X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="92058288" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Oct 2020 07:37:49 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Fri, 9 Oct 2020 07:37:48 -0700 Received: from soft-test08.microsemi.net (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Fri, 9 Oct 2020 07:37:46 -0700 From: Henrik Bjoernlund To: , , , , , , , , , CC: Henrik Bjoernlund , Horatiu Vultur Subject: [PATCH net-next v4 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM) Date: Fri, 9 Oct 2020 14:35:20 +0000 Message-ID: <20201009143530.2438738-1-henrik.bjoernlund@microchip.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. Connectivity Fault Management (CFM) comprises capabilities for detecting, verifying, and isolating connectivity failures in Virtual Bridged Networks. These capabilities can be used in networks operated by multiple independent organizations, each with restricted management access to each other’s equipment. CFM functions are partitioned as follows: — Path discovery — Fault detection — Fault verification and isolation — Fault notification — Fault recovery The primary CFM protocol shims are called Maintenance Points (MPs). A MP can be either a MEP or a MHF. The MEP: -It is the Maintenance association End Point described in 802.1Q section 19.2. -It is created on a specific level (1-7) and is assuring that no CFM frames are passing through this MEP on lower levels. -It initiates and terminates/validates CFM frames on its level. -It can only exist on a port that is related to a bridge. The MHF: -It is the Maintenance Domain Intermediate Point (MIP) Half Function (MHF) described in 802.1Q section 19.3. -It is created on a specific level (1-7). -It is extracting/injecting certain CFM frame on this level. -It can only exist on a port that is related to a bridge. -Currently not supported. There are defined the following CFM protocol functions: -Continuity Check -Loopback. Currently not supported. -Linktrace. Currently not supported. This CFM component supports create/delete of MEP instances and configuration of the different CFM protocols. Also status information can be fetched and delivered through notification due to defect status change. The user interacts with CFM using the 'cfm' user space client program, the client talks with the kernel using netlink. Any notification emitted by CFM from the kernel can be monitored in user space by starting 'cfm_server' program. Currently this 'cfm' and 'cfm_server' programs are standalone placed in a cfm repository https://github.com/microchip-ung/cfm but it is considered to integrate this into 'iproute2'. v1 -> v2 Added the CFM switchdev interface and also added utilization by calling the interface from the kernel CFM implementation trying to offload CFM functionality to HW. This offload (CFM driver) is currently not implemented. Corrections based on RCF comments: -The single CFM kernel implementation Patch is broken up into three patches. -Changed the list of MEP instances from list_head to hlist_head. -Removed unnecessary RCU list traversing. -Solved RCU unlocking problem. -Removed unnecessary comments. -Added ASSERT_RTNL() where required. -Shaping up on error messages. -Correction NETLINK br_fill_ifinfo() to be able to handle 'filter_mask' with multiple flags asserted. v2 -> v3 The switchdev definition and utilization has been removed as there was no switchdev implementation. Some compiling issues are fixed as Reported-by: kernel test robot . v3 -> v4 Fixed potential crash during hlist walk where elements are removed. Giving all commits unique titles. NETLINK implementation split into three commits. Commit "bridge: cfm: Bridge port remove" is merged with commit "bridge: cfm: Kernel space implementation of CFM. MEP create/delete." Reviewed-by: Horatiu Vultur Signed-off-by: Henrik Bjoernlund Henrik Bjoernlund (10): net: bridge: extend the process of special frames bridge: cfm: Add BRIDGE_CFM to Kconfig. bridge: uapi: cfm: Added EtherType used by the CFM protocol. bridge: cfm: Kernel space implementation of CFM. MEP create/delete. bridge: cfm: Kernel space implementation of CFM. CCM frame TX added. bridge: cfm: Kernel space implementation of CFM. CCM frame RX added. bridge: cfm: Netlink SET configuration Interface. bridge: cfm: Netlink GET configuration Interface. bridge: cfm: Netlink GET status Interface. bridge: cfm: Netlink Notifications. include/uapi/linux/cfm_bridge.h | 70 +++ include/uapi/linux/if_bridge.h | 125 +++++ include/uapi/linux/if_ether.h | 1 + include/uapi/linux/rtnetlink.h | 2 + net/bridge/Kconfig | 11 + net/bridge/Makefile | 2 + net/bridge/br_cfm.c | 884 ++++++++++++++++++++++++++++++++ net/bridge/br_cfm_netlink.c | 731 ++++++++++++++++++++++++++ net/bridge/br_device.c | 4 + net/bridge/br_if.c | 1 + net/bridge/br_input.c | 33 +- net/bridge/br_mrp.c | 19 +- net/bridge/br_netlink.c | 115 ++++- net/bridge/br_private.h | 76 ++- net/bridge/br_private_cfm.h | 147 ++++++ 15 files changed, 2199 insertions(+), 22 deletions(-) create mode 100644 include/uapi/linux/cfm_bridge.h create mode 100644 net/bridge/br_cfm.c create mode 100644 net/bridge/br_cfm_netlink.c create mode 100644 net/bridge/br_private_cfm.h