| Message ID | 20201021052437.3763-1-qiangqing.zhang@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | can: flexcan: add stop mode support for i.MX8QM | expand |
> -----Original Message----- > From: Joakim Zhang <qiangqing.zhang@nxp.com> > Sent: 2020年10月21日 13:25 > To: mkl@pengutronix.de; robh+dt@kernel.org; shawnguo@kernel.org; > s.hauer@pengutronix.de > Cc: kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; Ying Liu > <victor.liu@nxp.com>; linux-can@vger.kernel.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: [PATCH V4 0/6] can: flexcan: add stop mode support for i.MX8QM > > The first patch from Liu Ying aims to export SCU symbols for SoCs w/wo SCU, so > that no need to check CONFIG_IMX_SCU in the specific driver. > > The following patches are flexcan fixes and add stop mode support for > i.MX8QM. Hi Shawnguo, Could you please help review patch 1/6 and 5/6? Since flexcan driver depends on these. Thanks. For patch 1/6, it will benefit other drivers which cover SoCs w/wo SCU, such as i.MX Ethernet Controller driver (drivers/net/ethernet/freescale/fec_main.c). Best Regards, Joakim Zhang
Gentle Ping... @shawnguo@kernel.org, Could you please help review patch 1/6 and 5/6 in this patch set? Best Regards, Joakim Zhang > -----Original Message----- > From: Joakim Zhang <qiangqing.zhang@nxp.com> > Sent: 2020年10月21日 13:33 > To: mkl@pengutronix.de; robh+dt@kernel.org; shawnguo@kernel.org; > s.hauer@pengutronix.de > Cc: kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; Ying Liu > <victor.liu@nxp.com>; linux-can@vger.kernel.org; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: RE: [PATCH V4 0/6] can: flexcan: add stop mode support for i.MX8QM > > > > -----Original Message----- > > From: Joakim Zhang <qiangqing.zhang@nxp.com> > > Sent: 2020年10月21日 13:25 > > To: mkl@pengutronix.de; robh+dt@kernel.org; shawnguo@kernel.org; > > s.hauer@pengutronix.de > > Cc: kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; Ying Liu > > <victor.liu@nxp.com>; linux-can@vger.kernel.org; > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: [PATCH V4 0/6] can: flexcan: add stop mode support for > > i.MX8QM > > > > The first patch from Liu Ying aims to export SCU symbols for SoCs w/wo > > SCU, so that no need to check CONFIG_IMX_SCU in the specific driver. > > > > The following patches are flexcan fixes and add stop mode support for > > i.MX8QM. > > Hi Shawnguo, > > Could you please help review patch 1/6 and 5/6? Since flexcan driver depends > on these. Thanks. > > For patch 1/6, it will benefit other drivers which cover SoCs w/wo SCU, such as > i.MX Ethernet Controller driver (drivers/net/ethernet/freescale/fec_main.c). > > Best Regards, > Joakim Zhang
The first patch from Liu Ying aims to export SCU symbols for SoCs w/wo SCU, so that no need to check CONFIG_IMX_SCU in the specific driver. The following patches are flexcan fixes and add stop mode support for i.MX8QM. ChangeLogs: V3->V4: * can_idx->scu_idx. * return imx_scu_get_handle(&priv->sc_ipc_handle); * failed_canregister->failed_setup_stop_mode. V2->V3: * define IMX_SC_R_CAN(x) in rsrc.h * remove error message on -EPROBE_DEFER. * split disable wakeup patch into separate one. V1->V2: * split ECC fix patches into separate patches. * free can dev if failed to setup stop mode. * disable wakeup on flexcan_remove. * add FLEXCAN_IMX_SC_R_CAN macro helper. * fsl,can-index->fsl,scu-index. * move fsl,scu-index and priv->can_idx into * flexcan_setup_stop_mode_scfw() * prove failed if failed to setup stop mode. Joakim Zhang (5): dt-bindings: can: flexcan: fix fsl,clk-source property dt-bindings: can: flexcan: add fsl,scu-index property to indicate a resource can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN can: flexcan: add CAN wakeup function for i.MX8QM Liu Ying (1): firmware: imx: always export SCU symbols .../bindings/net/can/fsl-flexcan.txt | 8 +- drivers/net/can/flexcan.c | 131 +++++++++++++++--- include/dt-bindings/firmware/imx/rsrc.h | 1 + include/linux/firmware/imx/ipc.h | 15 ++ include/linux/firmware/imx/svc/misc.h | 23 +++ 5 files changed, 156 insertions(+), 22 deletions(-)