mbox series

[iproute2-next,0/2] ip: Nexthop flags extensions

Message ID 20201119135731.410986-1-idosch@idosch.org (mailing list archive)
Headers show
Series ip: Nexthop flags extensions | expand

Message

Ido Schimmel Nov. 19, 2020, 1:57 p.m. UTC
From: Ido Schimmel <idosch@nvidia.com>

Patch #1 prints the recently added 'RTNH_F_TRAP' flag.

Patch #2 makes sure that nexthop flags are always printed for nexthop
objects. Even when the nexthop does not have a device, such as a
blackhole nexthop or a group.

Example output with netdevsim:

# ip nexthop
id 1 via 192.0.2.2 dev eth0 scope link trap
id 2 blackhole trap
id 3 group 2 trap

Example output with mlxsw:

# ip nexthop
id 1 via 192.0.2.2 dev swp3 scope link offload
id 2 blackhole offload
id 3 group 2 offload

Tested with fib_nexthops.sh that uses "ip nexthop" output:

Tests passed: 164
Tests failed:   0

Ido Schimmel (2):
  ip route: Print "trap" nexthop indication
  nexthop: Always print nexthop flags

 ip/ipnexthop.c | 3 +--
 ip/iproute.c   | 2 ++
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

David Ahern Nov. 22, 2020, 7:47 p.m. UTC | #1
On 11/19/20 6:57 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> Patch #1 prints the recently added 'RTNH_F_TRAP' flag.
> 
> Patch #2 makes sure that nexthop flags are always printed for nexthop
> objects. Even when the nexthop does not have a device, such as a
> blackhole nexthop or a group.
> 
> Example output with netdevsim:
> 
> # ip nexthop
> id 1 via 192.0.2.2 dev eth0 scope link trap
> id 2 blackhole trap
> id 3 group 2 trap
> 
> Example output with mlxsw:
> 
> # ip nexthop
> id 1 via 192.0.2.2 dev swp3 scope link offload
> id 2 blackhole offload
> id 3 group 2 offload
> 
> Tested with fib_nexthops.sh that uses "ip nexthop" output:
> 
> Tests passed: 164
> Tests failed:   0
> 
> Ido Schimmel (2):
>   ip route: Print "trap" nexthop indication
>   nexthop: Always print nexthop flags
> 
>  ip/ipnexthop.c | 3 +--
>  ip/iproute.c   | 2 ++
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 

applied to iproute2-next, without preferential treatment.