mbox series

[net,0/4] nexthop: Various fixes

Message ID 20210107144824.1135691-1-idosch@idosch.org (mailing list archive)
Headers show
Series nexthop: Various fixes | expand

Message

Ido Schimmel Jan. 7, 2021, 2:48 p.m. UTC
From: Ido Schimmel <idosch@nvidia.com>

This series contains various fixes for the nexthop code. The bugs were
uncovered during the development of resilient nexthop groups.

Patches #1-#2 fix the error path of nexthop_create_group(). I was not
able to trigger these bugs with current code, but it is possible with
the upcoming resilient nexthop groups code which adds a user
controllable memory allocation further in the function.

Patch #3 fixes wrong validation of netlink attributes.

Patch #4 fixes wrong invocation of mausezahn in a selftest.

Ido Schimmel (3):
  nexthop: Fix off-by-one error in error path
  nexthop: Unlink nexthop group entry in error path
  selftests: fib_nexthops: Fix wrong mausezahn invocation

Petr Machata (1):
  nexthop: Bounce NHA_GATEWAY in FDB nexthop groups

 net/ipv4/nexthop.c                          | 6 ++++--
 tools/testing/selftests/net/fib_nexthops.sh | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

Comments

Jakub Kicinski Jan. 8, 2021, 2:50 a.m. UTC | #1
On Thu,  7 Jan 2021 16:48:20 +0200 Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> This series contains various fixes for the nexthop code. The bugs were
> uncovered during the development of resilient nexthop groups.
> 
> Patches #1-#2 fix the error path of nexthop_create_group(). I was not
> able to trigger these bugs with current code, but it is possible with
> the upcoming resilient nexthop groups code which adds a user
> controllable memory allocation further in the function.
> 
> Patch #3 fixes wrong validation of netlink attributes.
> 
> Patch #4 fixes wrong invocation of mausezahn in a selftest.

Applied, thanks!