| Message ID | 20210111113909.31702-1-pali@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber | expand |
On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > This is a third version of patches which add workarounds for > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > Russel's PATCH v2 2/3 was dropped from this patch series as > it is being handled separately. > > Pali Rohár (2): > net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips > net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant > > drivers/net/phy/sfp-bus.c | 15 +++++ > drivers/net/phy/sfp.c | 117 ++++++++++++++++++++++++++------------ > 2 files changed, 97 insertions(+), 35 deletions(-) I'm fine with Marek's commit message changes. Russell, Andrew, anything else is needed for these two patches?
On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > This is a third version of patches which add workarounds for > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > Russel's PATCH v2 2/3 was dropped from this patch series as > it is being handled separately. Andrew and Russel, are you fine with this third iteration of patches? Or are there still some issues which needs to be fixed? > Pali Rohár (2): > net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips > net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant > > drivers/net/phy/sfp-bus.c | 15 +++++ > drivers/net/phy/sfp.c | 117 ++++++++++++++++++++++++++------------ > 2 files changed, 97 insertions(+), 35 deletions(-) > > -- > 2.20.1 >
On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > This is a third version of patches which add workarounds for > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > Russel's PATCH v2 2/3 was dropped from this patch series as > > it is being handled separately. > > Andrew and Russel, are you fine with this third iteration of patches? > Or are there still some issues which needs to be fixed? PING! > > Pali Rohár (2): > > net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips > > net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant > > > > drivers/net/phy/sfp-bus.c | 15 +++++ > > drivers/net/phy/sfp.c | 117 ++++++++++++++++++++++++++------------ > > 2 files changed, 97 insertions(+), 35 deletions(-) > > > > -- > > 2.20.1 > >
On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > > This is a third version of patches which add workarounds for > > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > > > Russel's PATCH v2 2/3 was dropped from this patch series as > > > it is being handled separately. > > > > Andrew and Russel, are you fine with this third iteration of patches? > > Or are there still some issues which needs to be fixed? > > PING! What about the commit message suggestions from Marek?
On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > > On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > > > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > > > This is a third version of patches which add workarounds for > > > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > > > > > Russel's PATCH v2 2/3 was dropped from this patch series as > > > > it is being handled separately. > > > > > > Andrew and Russel, are you fine with this third iteration of patches? > > > Or are there still some issues which needs to be fixed? > > > > PING! > > What about the commit message suggestions from Marek? I have already wrote that I'm fine with those suggestions. It is the only thing to handle? If yes, should I send a new patch series with fixed commit messages?
On Mon, Jan 25, 2021 at 03:23:01PM +0100, Pali Rohár wrote: > On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > > > On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > > > > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > > > > This is a third version of patches which add workarounds for > > > > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > > > > > > > Russel's PATCH v2 2/3 was dropped from this patch series as > > > > > it is being handled separately. > > > > > > > > Andrew and Russel, are you fine with this third iteration of patches? > > > > Or are there still some issues which needs to be fixed? > > > > > > PING! > > > > What about the commit message suggestions from Marek? > > I have already wrote that I'm fine with those suggestions. > > It is the only thing to handle? If yes, should I send a new patch series > with fixed commit messages? Yes, because that's the way the netdev list works - patches sent to netdev go into patchwork, when they get reviewed and acks etc, patchwork updates itself. Jakub or David can then see what the status is and apply them to the net or net-next trees as appropriate. The "finished" patches need to be posted for this process to start. Thanks.
On Monday 25 January 2021 14:42:21 Russell King - ARM Linux admin wrote: > On Mon, Jan 25, 2021 at 03:23:01PM +0100, Pali Rohár wrote: > > On Monday 25 January 2021 14:16:44 Russell King - ARM Linux admin wrote: > > > On Mon, Jan 25, 2021 at 03:09:57PM +0100, Pali Rohár wrote: > > > > On Monday 18 January 2021 10:34:35 Pali Rohár wrote: > > > > > On Monday 11 January 2021 12:39:07 Pali Rohár wrote: > > > > > > This is a third version of patches which add workarounds for > > > > > > RTL8672/RTL9601C EEPROMs and Ubiquiti U-Fiber Instant SFP. > > > > > > > > > > > > Russel's PATCH v2 2/3 was dropped from this patch series as > > > > > > it is being handled separately. > > > > > > > > > > Andrew and Russel, are you fine with this third iteration of patches? > > > > > Or are there still some issues which needs to be fixed? > > > > > > > > PING! > > > > > > What about the commit message suggestions from Marek? > > > > I have already wrote that I'm fine with those suggestions. > > > > It is the only thing to handle? If yes, should I send a new patch series > > with fixed commit messages? > > Yes, because that's the way the netdev list works - patches sent to > netdev go into patchwork, when they get reviewed and acks etc, > patchwork updates itself. Jakub or David can then see what the status > is and apply them to the net or net-next trees as appropriate. Ok! If this is the only remaining issue, I will update commit messages and send a new patch series. I was just waiting for a response if somebody else has other comments or if somebody write that is fine with it. > The "finished" patches need to be posted for this process to start. > > Thanks.
> Ok! If this is the only remaining issue, I will update commit messages > and send a new patch series. I was just waiting for a response if > somebody else has other comments or if somebody write that is fine with > it. Hi Pali As a general rule of thumb, with netdev, wait 3 days and then send the next version. If the change request is minor, everybody seems to be in agreement, you can wait just one day. Please don't send new versions faster than that. Andrew