[net-next,V3,0/8] TLS device offload for Bond

Message

Tariq Toukan Jan. 17, 2021, 2:59 p.m. UTC

Hi,

This series opens TX and RX TLS device offload for bond interfaces.
This allows bond interfaces to benefit from capable lower devices.

We add a new ndo_sk_get_lower_dev() to be used to get the lower dev that
corresponds to a given socket.
The TLS module uses it to interact directly with the lowest device in
chain, and invoke the control operations in tlsdev_ops. This means that the
bond interface doesn't have his own struct tlsdev_ops instance and
derived logic/callbacks.

To keep simple track of the HW and SW TLS contexts, we bind each socket to
a specific lower device for the socket's whole lifetime. This is logically
valid (and similar to the SW kTLS behavior) in the following bond configuration,
so we restrict the offload support to it:

((mode == balance-xor) or (mode == 802.3ad))
and xmit_hash_policy == layer3+4.

In this design, TLS TX/RX offload feature flags of the bond device are
independent from the lower devices. They reflect the current features state,
but are not directly controllable.
This is because the bond driver is bypassed by the call to
ndo_sk_get_lower_dev(), without him knowing who the caller is.
The bond TLS feature flags are set/cleared only according to the configuration
of the mode and xmit_hash_policy.

Bypass is true only for the control flow. Packets in fast path still go through
the bond logic.

The design here differs from the xfrm/ipsec offload, where the bond driver
has his own copy of struct xfrmdev_ops and callbacks.

Regards,
Tariq

V3:
- Use "lower device" instead of "slave".
- Make TLS TX/RX devie offload feature flags non-controllable [Fixed].

V2:
- Declare RX support.
- Enhance the feature flags logic.
- Slight modifications for bond_set_xfrm_features().
- 

RFC:
- New design for the tlsdev_ops calls, introduce and use ndo_sk_get_slave()
  to interact directly with the slave netdev.
- Remove bond copy of tlsdev_ops callbacks.
- In TLS module: Use netdev_sk_get_lowest_dev(), give exceptions to some checks
  to allow bond support.


Tariq Toukan (8):
  net: netdevice: Add operation ndo_sk_get_lower_dev
  net/bonding: Take IP hash logic into a helper
  net/bonding: Implement ndo_sk_get_lower_dev
  net/bonding: Take update_features call out of XFRM funciton
  net/bonding: Implement TLS TX device offload
  net/bonding: Declare TLS RX device offload support
  net/tls: Device offload to use lowest netdevice in chain
  net/tls: Except bond interface from some TLS checks

 drivers/net/bonding/bond_main.c    | 138 +++++++++++++++++++++++++++--
 drivers/net/bonding/bond_options.c |  42 +++++++--
 include/linux/netdevice.h          |   4 +
 include/net/bonding.h              |   4 +
 net/core/dev.c                     |  33 +++++++
 net/tls/tls_device.c               |   4 +-
 net/tls/tls_device_fallback.c      |   2 +-
 7 files changed, 211 insertions(+), 16 deletions(-)

Comments

[e-mail] Jan. 19, 2021, 5:50 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Sun, 17 Jan 2021 16:59:41 +0200 you wrote:
> Hi,
> 
> This series opens TX and RX TLS device offload for bond interfaces.
> This allows bond interfaces to benefit from capable lower devices.
> 
> We add a new ndo_sk_get_lower_dev() to be used to get the lower dev that
> corresponds to a given socket.
> The TLS module uses it to interact directly with the lowest device in
> chain, and invoke the control operations in tlsdev_ops. This means that the
> bond interface doesn't have his own struct tlsdev_ops instance and
> derived logic/callbacks.
> 
> [...]

Here is the summary with links:
  - [net-next,V3,1/8] net: netdevice: Add operation ndo_sk_get_lower_dev
    https://git.kernel.org/netdev/net-next/c/719a402cf603
  - [net-next,V3,2/8] net/bonding: Take IP hash logic into a helper
    https://git.kernel.org/netdev/net-next/c/5b99854540e3
  - [net-next,V3,3/8] net/bonding: Implement ndo_sk_get_lower_dev
    https://git.kernel.org/netdev/net-next/c/007feb87fb15
  - [net-next,V3,4/8] net/bonding: Take update_features call out of XFRM funciton
    https://git.kernel.org/netdev/net-next/c/f45583de361d
  - [net-next,V3,5/8] net/bonding: Implement TLS TX device offload
    https://git.kernel.org/netdev/net-next/c/89df6a810470
  - [net-next,V3,6/8] net/bonding: Declare TLS RX device offload support
    https://git.kernel.org/netdev/net-next/c/dc5809f9e2b6
  - [net-next,V3,7/8] net/tls: Device offload to use lowest netdevice in chain
    https://git.kernel.org/netdev/net-next/c/153cbd137f0a
  - [net-next,V3,8/8] net/tls: Except bond interface from some TLS checks
    https://git.kernel.org/netdev/net-next/c/4e5a73329051

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html