From patchwork Tue Jan 26 17:40:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edwin Peer X-Patchwork-Id: 12048597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_NO_TEXT,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A560C433E0 for ; Tue, 26 Jan 2021 23:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDB562065E for ; Tue, 26 Jan 2021 23:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731763AbhAZXFS (ORCPT ); Tue, 26 Jan 2021 18:05:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390368AbhAZRlT (ORCPT ); Tue, 26 Jan 2021 12:41:19 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A21AC06174A for ; Tue, 26 Jan 2021 09:40:39 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id md11so2424303pjb.0 for ; Tue, 26 Jan 2021 09:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:mime-version; bh=vDkOXJVhuT5Vrzaa/J+ba97ZN6e3F+RaFVy9ev0wMv4=; b=ILC7NVMpDpANZWo+ja9TzCtnpUYZ3YBTGEd+QNtDuRD6tIEjhMo90kbDyiYetUX8lf uGnkQClW5PUd6HrUNE+YsbXua11xC83BeEabQXhHzV5b5tX9s4DLX5ncj0QJ7N96M19A A/n/tKqOeKTiN5yEhonXwG/kSV8/KHWjJDwbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=vDkOXJVhuT5Vrzaa/J+ba97ZN6e3F+RaFVy9ev0wMv4=; b=E8/h8UUkVgerNH3PSXSepVs9AKW2ojFAW+e22F/yUjv7CXTYpFlbxkfu6l9dn//vfR 3QO5foJQuUFWSFsJ8XnJ85w/U11Plu7oEixzj3ra4kpQeTCmlTVkrvZkpjtM8Iimjlqt MF45nLoPAVP7PP0kW4V8WjW44Dgsq5Mejyrp+/L/5P39Z+fAYJikuYVd60OZteaZFZso wWj5zsaIfHpVkB18alJxFHRgEBnQCrZH2xJ1ZCL/H/aTZ9eCEH7ctxEEAuWFLNe8FfWM wj5ebgSDwcryhsoFhk+LZODqpt2NfU9dAKvNazpSX7P+t/uYHJFdRKqydr1X1ZSfAutb 5vQQ== X-Gm-Message-State: AOAM531+T9Rfu+lZkT2VSmOWxqiFX8VWMmqYP3ZT55edT24OfA/iLo0c AmJ49ZM7+jnKbr4pLBjmgRKOOVBs7U8XPTiiC+fPNZwz5CWXmht9k7TR0MaQ22LVs2nql/wtuwJ TYw9IzuCpxQOi3CWgCKclrC0pdxLOSsLDbpQGLP3hK+93UVF2KVyfLRJh7ySt61+5nllX4vup X-Google-Smtp-Source: ABdhPJx2ytBIbOPBeWS4/QNk6Y0wNd5e2Jcy84vMQoQdwmXQCb8149VvTAg/3wE1PwCv3zecOY9eSQ== X-Received: by 2002:a17:90a:d990:: with SMTP id d16mr953917pjv.16.1611682838313; Tue, 26 Jan 2021 09:40:38 -0800 (PST) Received: from hex.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id n15sm2895269pjk.57.2021.01.26.09.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jan 2021 09:40:36 -0800 (PST) From: Edwin Peer To: netdev@vger.kernel.org Cc: Edwin Peer , Jakub Kicinski , Andrew Gospodarek , Michael Chan , Stephen Hemminger , Michal Kubecek , David Ahern Subject: [PATCH net-next v2 0/1] support more VFs in RTM_GETLINK Date: Tue, 26 Jan 2021 09:40:23 -0800 Message-Id: <20210126174024.185001-1-edwin.peer@broadcom.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org RTM_GETLINK for greater than about 220 VFs truncates IFLA_VFINFO_LIST due to the maximum reach of nlattr's nla_len being exceeded. There is not a lot of enthusiasm for extensive fixes to the deprecated netlink ABI for VF config, but there appears to be even less appetite for the kinds of work arounds that would be necessitated in order to truly keep it frozen [1]. Any kind of fix for this at the RTM_GETLINK VF API layer is also a no go [2]. For now, lets fix the bits that are uncontroversial so that a naked 'ip link show' (without stats) works. v2: Drop the pieces that require further discussion. [1] https://lore.kernel.org/netdev/20210115225950.18762-1-edwin.peer@broadcom.com/ [2] https://marc.info/?l=linux-netdev&m=161163943811663 (missing on lore) Edwin Peer (1): rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO net/core/rtnetlink.c | 96 +++++++++++++++++++++++--------------------- 1 file changed, 51 insertions(+), 45 deletions(-)