| Message ID | 20210225234319.336131-1-songliubraving@fb.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | bpf: enable task local storage for tracing programs | expand |
On Thu, Feb 25, 2021 at 03:43:13PM -0800, Song Liu wrote: > This set enables task local storage for non-BPF_LSM programs. > > It is common for tracing BPF program to access per-task data. Currently, > these data are stored in hash tables with pid as the key. In > bcc/libbpftools [1], 9 out of 23 tools use such hash tables. However, > hash table is not ideal for many use case. Task local storage provides > better usability and performance for BPF programs. Please refer to 6/6 for > some performance comparison of task local storage vs. hash table. Thanks for the patches. Acked-by: Martin KaFai Lau <kafai@fb.com>
On Thu, Feb 25, 2021 at 4:04 PM Martin KaFai Lau <kafai@fb.com> wrote: > > On Thu, Feb 25, 2021 at 03:43:13PM -0800, Song Liu wrote: > > This set enables task local storage for non-BPF_LSM programs. > > > > It is common for tracing BPF program to access per-task data. Currently, > > these data are stored in hash tables with pid as the key. In > > bcc/libbpftools [1], 9 out of 23 tools use such hash tables. However, > > hash table is not ideal for many use case. Task local storage provides > > better usability and performance for BPF programs. Please refer to 6/6 for > > some performance comparison of task local storage vs. hash table. > Thanks for the patches. > > Acked-by: Martin KaFai Lau <kafai@fb.com> Applied. Thanks. 9 out of 23 libbpf-tools will significantly reduce the tracing overhead. Hooray!
This set enables task local storage for non-BPF_LSM programs. It is common for tracing BPF program to access per-task data. Currently, these data are stored in hash tables with pid as the key. In bcc/libbpftools [1], 9 out of 23 tools use such hash tables. However, hash table is not ideal for many use case. Task local storage provides better usability and performance for BPF programs. Please refer to 6/6 for some performance comparison of task local storage vs. hash table. Changes v5 => v6: 1. Add inc/dec bpf_task_storage_busy in bpf_local_storage_map_free(). Changes v4 => v5: 1. Fix build w/o CONFIG_NET. (kernel test robot) 2. Remove unnecessary check for !task_storage_ptr(). (Martin) 3. Small changes in commit logs. Changes v3 => v4: 1. Prevent deadlock from recursive calls of bpf_task_storage_[get|delete]. (2/6 checks potential deadlock and fails over, 4/6 adds a selftest). Changes v2 => v3: 1. Make the selftest more robust. (Andrii) 2. Small changes with runqslower. (Andrii) 3. Shortern CC list to make it easy for vger. Changes v1 => v2: 1. Do not allocate task local storage when the task is being freed. 2. Revise the selftest and added a new test for a task being freed. 3. Minor changes in runqslower. Song Liu (6): bpf: enable task local storage for tracing programs bpf: prevent deadlock from recursive bpf_task_storage_[get|delete] selftests/bpf: add non-BPF_LSM test for task local storage selftests/bpf: test deadlock from recursive bpf_task_storage_[get|delete] bpf: runqslower: prefer using local vmlimux to generate vmlinux.h bpf: runqslower: use task local storage include/linux/bpf.h | 7 ++ include/linux/bpf_local_storage.h | 3 +- include/linux/bpf_lsm.h | 22 ---- include/linux/bpf_types.h | 2 +- include/linux/sched.h | 5 + kernel/bpf/Makefile | 3 +- kernel/bpf/bpf_inode_storage.c | 2 +- kernel/bpf/bpf_local_storage.c | 39 ++++--- kernel/bpf/bpf_lsm.c | 4 - kernel/bpf/bpf_task_storage.c | 100 +++++++++++------- kernel/fork.c | 5 + kernel/trace/bpf_trace.c | 4 + net/core/bpf_sk_storage.c | 2 +- tools/bpf/runqslower/Makefile | 5 +- tools/bpf/runqslower/runqslower.bpf.c | 33 +++--- .../bpf/prog_tests/task_local_storage.c | 92 ++++++++++++++++ .../selftests/bpf/progs/task_local_storage.c | 64 +++++++++++ .../bpf/progs/task_local_storage_exit_creds.c | 32 ++++++ .../selftests/bpf/progs/task_ls_recursion.c | 70 ++++++++++++ 19 files changed, 398 insertions(+), 96 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/task_local_storage.c create mode 100644 tools/testing/selftests/bpf/progs/task_local_storage.c create mode 100644 tools/testing/selftests/bpf/progs/task_local_storage_exit_creds.c create mode 100644 tools/testing/selftests/bpf/progs/task_ls_recursion.c -- 2.24.1