| Message ID | 20210315163450.254396-1-sgarzare@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | vdpa: add vdpa simulator for block device | expand |
Hi Michael, do you think this series is in an acceptable state to be queued for the next merge window? All patches should be already acked by Jason, let me know if I need to change anything. Thanks, Stefano On Mon, Mar 15, 2021 at 05:34:36PM +0100, Stefano Garzarella wrote: >v4: >- added support for iproute2 vdpa management tool in vdpa_sim_blk >- removed get/set_config patches > - 'vdpa: add return value to get_config/set_config callbacks' > - 'vhost/vdpa: remove vhost_vdpa_config_validate()' >- added get_config_size() patches > - 'vdpa: add get_config_size callback in vdpa_config_ops' > - 'vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate()' > >v3: https://lore.kernel.org/lkml/20210204172230.85853-1-sgarzare@redhat.com/ >v2: https://lore.kernel.org/lkml/20210128144127.113245-1-sgarzare@redhat.com/ >v1: https://lore.kernel.org/lkml/93f207c0-61e6-3696-f218-e7d7ea9a7c93@redhat.com/ > >This series is the second part of the v1 linked above. The first part with >refactoring of vdpa_sim has already been merged. > >The patches are based on Max Gurtovoy's work and extend the block simulator to >have a ramdisk behaviour. > >As mentioned in the v1 there was 2 issues and I fixed them in this series: >1. The identical mapping in the IOMMU used until now in vdpa_sim created issues > when mapping different virtual pages with the same physical address. > Fixed by patch "vdpa_sim: use iova module to allocate IOVA addresses" > >2. There was a race accessing the IOMMU between the vdpasim_blk_work() and the > device driver that map/unmap DMA regions. Fixed by patch "vringh: add > 'iotlb_lock' to synchronize iotlb accesses" > >I used the Xie's patch coming from VDUSE series to allow vhost-vdpa to use >block devices, and I added get_config_size() callback to allow any device >in vhost-vdpa. > >The series also includes small fixes for vringh, vdpa, and vdpa_sim that I >discovered while implementing and testing the block simulator. > >Thanks for your feedback, >Stefano > >Max Gurtovoy (1): > vdpa: add vdpa simulator for block device > >Stefano Garzarella (12): > vdpa_sim: use iova module to allocate IOVA addresses > vringh: add 'iotlb_lock' to synchronize iotlb accesses > vringh: reset kiov 'consumed' field in __vringh_iov() > vringh: explain more about cleaning riov and wiov > vringh: implement vringh_kiov_advance() > vringh: add vringh_kiov_length() helper > vdpa_sim: cleanup kiovs in vdpasim_free() > vdpa: add get_config_size callback in vdpa_config_ops > vhost/vdpa: use get_config_size callback in > vhost_vdpa_config_validate() > vdpa_sim_blk: implement ramdisk behaviour > vdpa_sim_blk: handle VIRTIO_BLK_T_GET_ID > vdpa_sim_blk: add support for vdpa management tool > >Xie Yongji (1): > vhost/vdpa: Remove the restriction that only supports virtio-net > devices > > drivers/vdpa/vdpa_sim/vdpa_sim.h | 2 + > include/linux/vdpa.h | 4 + > include/linux/vringh.h | 19 +- > drivers/vdpa/ifcvf/ifcvf_main.c | 6 + > drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 + > drivers/vdpa/vdpa_sim/vdpa_sim.c | 127 ++++++---- > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 338 +++++++++++++++++++++++++++ > drivers/vdpa/virtio_pci/vp_vdpa.c | 8 + > drivers/vhost/vdpa.c | 15 +- > drivers/vhost/vringh.c | 69 ++++-- > drivers/vdpa/Kconfig | 8 + > drivers/vdpa/vdpa_sim/Makefile | 1 + > 12 files changed, 529 insertions(+), 74 deletions(-) > create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c > >-- >2.30.2 > >_______________________________________________ >Virtualization mailing list >Virtualization@lists.linux-foundation.org >https://lists.linuxfoundation.org/mailman/listinfo/virtualization >
v4: - added support for iproute2 vdpa management tool in vdpa_sim_blk - removed get/set_config patches - 'vdpa: add return value to get_config/set_config callbacks' - 'vhost/vdpa: remove vhost_vdpa_config_validate()' - added get_config_size() patches - 'vdpa: add get_config_size callback in vdpa_config_ops' - 'vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate()' v3: https://lore.kernel.org/lkml/20210204172230.85853-1-sgarzare@redhat.com/ v2: https://lore.kernel.org/lkml/20210128144127.113245-1-sgarzare@redhat.com/ v1: https://lore.kernel.org/lkml/93f207c0-61e6-3696-f218-e7d7ea9a7c93@redhat.com/ This series is the second part of the v1 linked above. The first part with refactoring of vdpa_sim has already been merged. The patches are based on Max Gurtovoy's work and extend the block simulator to have a ramdisk behaviour. As mentioned in the v1 there was 2 issues and I fixed them in this series: 1. The identical mapping in the IOMMU used until now in vdpa_sim created issues when mapping different virtual pages with the same physical address. Fixed by patch "vdpa_sim: use iova module to allocate IOVA addresses" 2. There was a race accessing the IOMMU between the vdpasim_blk_work() and the device driver that map/unmap DMA regions. Fixed by patch "vringh: add 'iotlb_lock' to synchronize iotlb accesses" I used the Xie's patch coming from VDUSE series to allow vhost-vdpa to use block devices, and I added get_config_size() callback to allow any device in vhost-vdpa. The series also includes small fixes for vringh, vdpa, and vdpa_sim that I discovered while implementing and testing the block simulator. Thanks for your feedback, Stefano Max Gurtovoy (1): vdpa: add vdpa simulator for block device Stefano Garzarella (12): vdpa_sim: use iova module to allocate IOVA addresses vringh: add 'iotlb_lock' to synchronize iotlb accesses vringh: reset kiov 'consumed' field in __vringh_iov() vringh: explain more about cleaning riov and wiov vringh: implement vringh_kiov_advance() vringh: add vringh_kiov_length() helper vdpa_sim: cleanup kiovs in vdpasim_free() vdpa: add get_config_size callback in vdpa_config_ops vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate() vdpa_sim_blk: implement ramdisk behaviour vdpa_sim_blk: handle VIRTIO_BLK_T_GET_ID vdpa_sim_blk: add support for vdpa management tool Xie Yongji (1): vhost/vdpa: Remove the restriction that only supports virtio-net devices drivers/vdpa/vdpa_sim/vdpa_sim.h | 2 + include/linux/vdpa.h | 4 + include/linux/vringh.h | 19 +- drivers/vdpa/ifcvf/ifcvf_main.c | 6 + drivers/vdpa/mlx5/net/mlx5_vnet.c | 6 + drivers/vdpa/vdpa_sim/vdpa_sim.c | 127 ++++++---- drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 338 +++++++++++++++++++++++++++ drivers/vdpa/virtio_pci/vp_vdpa.c | 8 + drivers/vhost/vdpa.c | 15 +- drivers/vhost/vringh.c | 69 ++++-- drivers/vdpa/Kconfig | 8 + drivers/vdpa/vdpa_sim/Makefile | 1 + 12 files changed, 529 insertions(+), 74 deletions(-) create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim_blk.c