[net-next,0/1] taprio: Handle short intervals and large packets

Message

Kurt Kanzenbach March 18, 2021, 7:34 a.m. UTC

Hi,

there is a problem with the software implementation of TAPRIO and TCP
communication. When using short intervals e.g. below one millisecond, large
packets won't be transmitted. That's because the software implementation takes
the packet length and calculates the transmission time. If the transmission time
is larger than the configured interval, no packet will be transmitted. Fix that
by segmenting the skb for the software implementation.

Tested with software only and full hardware offloading applied using iperf3.

Vinicius, do you mind testing as well?

Changes since RFC:

 * Move segmentation, so that timestamps for tx assisted mode are
   calculated for the segments
 * Skip it for the full hardware offloading case

Previous versions:

 * https://lkml.kernel.org/netdev/[e-mail]/

Kurt Kanzenbach (1):
  taprio: Handle short intervals and large packets

 net/sched/sch_taprio.c | 64 +++++++++++++++++++++++++++++++++++-------
 1 file changed, 54 insertions(+), 10 deletions(-)

Comments

[e-mail] March 19, 2021, 7:10 p.m. UTC | #1

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 18 Mar 2021 08:34:54 +0100 you wrote:
> Hi,
> 
> there is a problem with the software implementation of TAPRIO and TCP
> communication. When using short intervals e.g. below one millisecond, large
> packets won't be transmitted. That's because the software implementation takes
> the packet length and calculates the transmission time. If the transmission time
> is larger than the configured interval, no packet will be transmitted. Fix that
> by segmenting the skb for the software implementation.
> 
> [...]

Here is the summary with links:
  - [net-next,1/1] taprio: Handle short intervals and large packets
    https://git.kernel.org/netdev/net-next/c/497cc00224cf

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html