From patchwork Wed Mar 31 12:26:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Lobakin X-Patchwork-Id: 12175399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D92EC4363F for ; Wed, 31 Mar 2021 12:33:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C1DD619AA for ; Wed, 31 Mar 2021 12:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235461AbhCaM0g (ORCPT ); Wed, 31 Mar 2021 08:26:36 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:51497 "EHLO mail-40133.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235424AbhCaM01 (ORCPT ); Wed, 31 Mar 2021 08:26:27 -0400 Date: Wed, 31 Mar 2021 12:26:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1617193578; bh=IJiIJLP9J3EbXGDv7FrrNHW4zk0L7+DgfXGI5q66nWw=; h=Date:To:From:Cc:Reply-To:Subject:From; b=ltGS1PR9i6yTJZSOPnOwObymChUFQ7ZmS3sE1OIB0ZrMOKq+vd6Qcn1do+C/ln7XK VQDnu0bEqCI09K7hbmIQ450xokR5AYaun2ha7kCX4NCMz3GKc6+VsQzUM/hrgnTUwT FugM39lzgFdOVrFCoK/vPT6ZbDanEesBwOC0la8YqnWulyTRO9o1WTCeTPvpeU/nRj hSRvA8eIfGr+r82OsEfiR/HDEjTfZNO2930uf7yFYA3baQ4kHNjvta7dQsw8/1qNcP jnS/ioUlSyjYpHM6XB96VM/4Zi8x2IO/tFwLxvqH8bPkeFOfLwT3s2xRUFPoRNb9hV Zemyw5xn8fS1Q== To: Alexei Starovoitov , Daniel Borkmann From: Alexander Lobakin Cc: Xuan Zhuo , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Jonathan Lemon , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Alexander Lobakin , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH v2 bpf-next 0/2] xsk: introduce generic almost-zerocopy xmit Message-ID: <20210331122602.6000-1-alobakin@pm.me> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net This series is based on the exceptional generic zerocopy xmit logics initially introduced by Xuan Zhuo. It extends it the way that it could cover all the sane drivers, not only the ones that are capable of xmitting skbs with no linear space. The first patch is a random while-we-are-here improvement over full-copy path, and the second is the main course. See the individual commit messages for the details. The original (full-zerocopy) path is still here and still generally faster, but for now it seems like virtio_net will remain the only user of it, at least for a considerable period of time. From v1 [0]: - don't add a whole SMP_CACHE_BYTES because of only two bytes (NET_IP_ALIGN); - switch to zerocopy if the frame is 129 bytes or longer, not 128. 128 still fit to kmalloc-512, while a zerocopy skb is always kmalloc-1024 -> can potentially be slower on this frame size. [0] https://lore.kernel.org/netdev/20210330231528.546284-1-alobakin@pm.me Alexander Lobakin (2): xsk: speed-up generic full-copy xmit xsk: introduce generic almost-zerocopy xmit net/xdp/xsk.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) --- Well, this is untested. I currently don't have an access to my setup and is bound by moving to another country, but as I don't know for sure at the moment when I'll get back to work on the kernel next time, I found it worthy to publish this now -- if any further changes will be required when I already will be out-of-sight, maybe someone could carry on to make a another revision and so on (I'm still here for any questions, comments, reviews and improvements till the end of this week). But this *should* work with all the sane drivers. If a particular one won't handle this, it's likely ill. Any tests are highly appreciated. Thanks! -- 2.31.1