mbox series

[V1,net-next,0/2] net: fec: fix TX bandwidth fluctuations

Message ID 20210527120722.16965-1-qiangqing.zhang@nxp.com (mailing list archive)
Headers show
Series net: fec: fix TX bandwidth fluctuations | expand

Message

Joakim Zhang May 27, 2021, 12:07 p.m. UTC 
This patch set intends to fix TX bandwidth fluctuations, any feedback would be appreciated.

---
ChangeLogs:
	V1: remove RFC tag, RFC discussions please turn to below:
	    https://lore.kernel.org/lkml/YK0Ce5YxR2WYbrAo@lunn.ch/T/

Fugang Duan (1):
  net: fec: add ndo_select_queue to fix TX bandwidth fluctuations

Joakim Zhang (1):
  net: fec: add FEC_QUIRK_HAS_MULTI_QUEUES represents i.MX6SX ENET IP

 drivers/net/ethernet/freescale/fec.h      |  5 +++
 drivers/net/ethernet/freescale/fec_main.c | 43 ++++++++++++++++++++---
 2 files changed, 43 insertions(+), 5 deletions(-)

Comments

Joakim Zhang May 27, 2021, 12:10 p.m. UTC | #1 
Hi Frieder,

As we talked before, could you please help test the patches when you are free? Thanks.

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Joakim Zhang <qiangqing.zhang@nxp.com>
> Sent: 2021年5月27日 20:07
> To: davem@davemloft.net; kuba@kernel.org; frieder.schrempf@kontron.de;
> andrew@lunn.ch
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth fluctuations
> 
> This patch set intends to fix TX bandwidth fluctuations, any feedback would be
> appreciated.
> 
> ---
> ChangeLogs:
> 	V1: remove RFC tag, RFC discussions please turn to below:
> 	    https://lore.kernel.org/lkml/YK0Ce5YxR2WYbrAo@lunn.ch/T/
> 
> Fugang Duan (1):
>   net: fec: add ndo_select_queue to fix TX bandwidth fluctuations
> 
> Joakim Zhang (1):
>   net: fec: add FEC_QUIRK_HAS_MULTI_QUEUES represents i.MX6SX ENET IP
> 
>  drivers/net/ethernet/freescale/fec.h      |  5 +++
>  drivers/net/ethernet/freescale/fec_main.c | 43 ++++++++++++++++++++---
>  2 files changed, 43 insertions(+), 5 deletions(-)
> 
> --
> 2.17.1
Andrew Lunn May 27, 2021, 2:05 p.m. UTC | #2 
On Thu, May 27, 2021 at 12:10:47PM +0000, Joakim Zhang wrote:
> 
> Hi Frieder,
> 
> As we talked before, could you please help test the patches when you are free? Thanks.

Hi Frieder

If you can, could you also test it with traffic with a mixture of VLAN
priorities. You might want to force the link to 10Full, so you can
overload it. Then see what traffic actually makes it through.

	 Andrew
Joakim Zhang June 8, 2021, 3:23 a.m. UTC | #3 
Hi Frieder,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: 2021年5月27日 22:06
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: davem@davemloft.net; kuba@kernel.org; frieder.schrempf@kontron.de;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: Re: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth fluctuations
> 
> On Thu, May 27, 2021 at 12:10:47PM +0000, Joakim Zhang wrote:
> >
> > Hi Frieder,
> >
> > As we talked before, could you please help test the patches when you are
> free? Thanks.
> 
> Hi Frieder
> 
> If you can, could you also test it with traffic with a mixture of VLAN priorities.
> You might want to force the link to 10Full, so you can overload it. Then see
> what traffic actually makes it through.

Did your mailbox get bombed, let you miss this mail, hope you can see this reply.

Could you please give some feedback if it is possible? Thanks :-)

Best Regards,
Joakim Zhang
> 	 Andrew
Frieder Schrempf June 8, 2021, 2:18 p.m. UTC | #4 
Hi Joakim, hi Andrew,

On 08.06.21 05:23, Joakim Zhang wrote:
> 
> Hi Frieder,
> 
>> -----Original Message-----
>> From: Andrew Lunn <andrew@lunn.ch>
>> Sent: 2021年5月27日 22:06
>> To: Joakim Zhang <qiangqing.zhang@nxp.com>
>> Cc: davem@davemloft.net; kuba@kernel.org; frieder.schrempf@kontron.de;
>> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
>> <linux-imx@nxp.com>
>> Subject: Re: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth fluctuations
>>
>> On Thu, May 27, 2021 at 12:10:47PM +0000, Joakim Zhang wrote:
>>>
>>> Hi Frieder,
>>>
>>> As we talked before, could you please help test the patches when you are
>> free? Thanks.
>>
>> Hi Frieder
>>
>> If you can, could you also test it with traffic with a mixture of VLAN priorities.
>> You might want to force the link to 10Full, so you can overload it. Then see
>> what traffic actually makes it through.
> 
> Did your mailbox get bombed, let you miss this mail, hope you can see this reply.
> 
> Could you please give some feedback if it is possible? Thanks :-)

Thanks for the patches! As far as the bandwidth drops are concerned, this solves the problem. According to my simple iperf tests the untagged TX traffic now always goes to queue 0 and therefore doesn't see any random bandwidth limitations anymore. 

Regarding Andrew's request for testing this with some tagged traffic mix, my problem is that though I have used VLANs before and know how to set them up, I've never done anything with QoS, so I don't really now how to set the priorities (looks like I need to set up internal priorities and egress mapping somehow!?). If you have any pointers for this it would be appreciated. I probably could do some quick verification tests, but I don't have the time to really dive into the topic.

Best regards
Frieder
Joakim Zhang June 9, 2021, 12:03 p.m. UTC | #5 
Hi Frieder,

> -----Original Message-----
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> Sent: 2021年6月8日 22:19
> To: Joakim Zhang <qiangqing.zhang@nxp.com>; Andrew Lunn
> <andrew@lunn.ch>
> Cc: davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth fluctuations
> 
> Hi Joakim, hi Andrew,
> 
> On 08.06.21 05:23, Joakim Zhang wrote:
> >
> > Hi Frieder,
> >
> >> -----Original Message-----
> >> From: Andrew Lunn <andrew@lunn.ch>
> >> Sent: 2021年5月27日 22:06
> >> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> >> Cc: davem@davemloft.net; kuba@kernel.org;
> >> frieder.schrempf@kontron.de; netdev@vger.kernel.org;
> >> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> >> Subject: Re: [PATCH V1 net-next 0/2] net: fec: fix TX bandwidth
> >> fluctuations
> >>
> >> On Thu, May 27, 2021 at 12:10:47PM +0000, Joakim Zhang wrote:
> >>>
> >>> Hi Frieder,
> >>>
> >>> As we talked before, could you please help test the patches when you
> >>> are
> >> free? Thanks.
> >>
> >> Hi Frieder
> >>
> >> If you can, could you also test it with traffic with a mixture of VLAN
> priorities.
> >> You might want to force the link to 10Full, so you can overload it.
> >> Then see what traffic actually makes it through.
> >
> > Did your mailbox get bombed, let you miss this mail, hope you can see this
> reply.
> >
> > Could you please give some feedback if it is possible? Thanks :-)
> 
> Thanks for the patches! As far as the bandwidth drops are concerned, this
> solves the problem. According to my simple iperf tests the untagged TX traffic
> now always goes to queue 0 and therefore doesn't see any random bandwidth
> limitations anymore.
>
> Regarding Andrew's request for testing this with some tagged traffic mix, my
> problem is that though I have used VLANs before and know how to set them up,
> I've never done anything with QoS, so I don't really now how to set the
> priorities (looks like I need to set up internal priorities and egress mapping
> somehow!?). If you have any pointers for this it would be appreciated. I
> probably could do some quick verification tests, but I don't have the time to
> really dive into the topic.

Thanks a lot for your testing! Could I add your t-b and r-b tag when I repost the patches to change functions into static as Jakub commented before?

Best Regards,
Joakim Zhang
> 
> Best regards
> Frieder