From patchwork Fri Jun 4 22:09:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinicius Costa Gomes X-Patchwork-Id: 12300865 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C1E1C48BC2 for ; Fri, 4 Jun 2021 22:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E94686140C for ; Fri, 4 Jun 2021 22:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230435AbhFDWL4 (ORCPT ); Fri, 4 Jun 2021 18:11:56 -0400 Received: from mga05.intel.com ([192.55.52.43]:24251 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbhFDWLw (ORCPT ); Fri, 4 Jun 2021 18:11:52 -0400 IronPort-SDR: oYYSlq6sccd3p1hnaj951Sr39H7YD/fYD4W8qPtfDmGvXaGt6eq+q1rwpktR0TaK1LEL5c8UxR i5xhpRzQeUGA== X-IronPort-AV: E=McAfee;i="6200,9189,10005"; a="290007339" X-IronPort-AV: E=Sophos;i="5.83,249,1616482800"; d="scan'208";a="290007339" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 15:10:04 -0700 IronPort-SDR: fH1wBMzQEaV0sQM2oOdiGTN+FdFsUnuXdxMYDC3JP6bLCm6TUMnV41BL/Gg07EWpgM9XIudCsA PFiI3f2LyT/g== X-IronPort-AV: E=Sophos;i="5.83,249,1616482800"; d="scan'208";a="439326605" Received: from lmrivera-mobl.amr.corp.intel.com (HELO localhost.localdomain) ([10.251.24.65]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 15:10:03 -0700 From: Vinicius Costa Gomes To: intel-wired-lan@lists.osuosl.org Cc: Vinicius Costa Gomes , sasha.neftin@intel.com, anthony.l.nguyen@intel.com, linux-pci@vger.kernel.org, bhelgaas@google.com, netdev@vger.kernel.org, mlichvar@redhat.com, richardcochran@gmail.com, hch@infradead.org, helgaas@kernel.org Subject: [PATCH next-queue v4 0/4] igc: Add support for PCIe PTM Date: Fri, 4 Jun 2021 15:09:29 -0700 Message-Id: <20210604220933.3974558-1-vinicius.gomes@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Changes from v3: - More descriptive commit messages and comments (Bjorn Helgaas); - Added a pcie_ptm_enabled() helper (Bjorn Helgaas); Changes from v2: - Now the PTM timestamps are retrieved synchronously with the ioctl(); - Fixed some typos in constants; - The IGC_PTM_STAT register is write-1-to-clear, document this more clearly; Changes from v1: - This now should cross compile better, convert_art_ns_to_tsc() will only be used if CONFIG_X86_TSC is enabled; - PCIe PTM errors reported by the NIC are logged and PTM cycles are restarted in case an error is detected; Original cover letter (lightly edited): This adds support for PCIe PTM (Precision Time Measurement) to the igc driver. PCIe PTM allows the NIC and Host clocks to be compared more precisely, improving the clock synchronization accuracy. Patch 1/4 reverts a commit that made pci_enable_ptm() private to the PCI subsystem, reverting makes it possible for it to be called from the drivers. Patch 2/4 adds the pcie_ptm_enabled() helper. Patch 3/4 calls pci_enable_ptm() from the igc driver. Patch 4/4 implements the PCIe PTM support. It adds a workqueue that reads the PTM registers periodically and collects the information so a subsequent call to getcrosststamp() has all the timestamps needed. Some questions are raised (also pointed out in the commit message): 1. Using convert_art_ns_to_tsc() is too x86 specific, there should be a common way to create a 'system_counterval_t' from a timestamp. 2. convert_art_ns_to_tsc() says that it should only be used when X86_FEATURE_TSC_KNOWN_FREQ is true, but during tests it works even when it returns false. Should that check be done? Cheers, Vinicius Costa Gomes (4): Revert "PCI: Make pci_enable_ptm() private" PCI: Add pcie_ptm_enabled() igc: Enable PCIe PTM igc: Add support for PTP getcrosststamp() drivers/net/ethernet/intel/igc/igc.h | 1 + drivers/net/ethernet/intel/igc/igc_defines.h | 31 ++++ drivers/net/ethernet/intel/igc/igc_main.c | 6 + drivers/net/ethernet/intel/igc/igc_ptp.c | 182 +++++++++++++++++++ drivers/net/ethernet/intel/igc/igc_regs.h | 23 +++ drivers/pci/pci.h | 3 - drivers/pci/pcie/ptm.c | 9 + include/linux/pci.h | 10 + 8 files changed, 262 insertions(+), 3 deletions(-)