| Message ID | 20211009210341.6291-1-quentin@isovalent.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fixes for bpftool's Makefile | expand |
Quentin Monnet wrote: > This set contains one fix for bpftool's Makefile, to make sure that the > headers internal to libbpf are installed properly even if we add more > headers to the relevant Makefile variable in the future (although we'd like > to avoid that if possible). > > The other patches aim at cleaning up the output from the Makefile, in > particular when running the command "make" another time after bpftool is > built. > > Quentin Monnet (3): > bpftool: fix install for libbpf's internal header(s) > bpftool: do not FORCE-build libbpf > bpftool: turn check on zlib from a phony target into a conditional > error > > tools/bpf/bpftool/Makefile | 29 +++++++++++++++-------------- > 1 file changed, 15 insertions(+), 14 deletions(-) > > -- > 2.30.2 > I'm not a Makefile expert, but from my side these look good. Thanks. Acked-by: John Fastabend <john.fastabend@gmail.com>
On Mon, Oct 18, 2021 at 7:05 AM John Fastabend <john.fastabend@gmail.com> wrote: > > Quentin Monnet wrote: > > This set contains one fix for bpftool's Makefile, to make sure that the > > headers internal to libbpf are installed properly even if we add more > > headers to the relevant Makefile variable in the future (although we'd like > > to avoid that if possible). > > > > The other patches aim at cleaning up the output from the Makefile, in > > particular when running the command "make" another time after bpftool is > > built. > > > > Quentin Monnet (3): > > bpftool: fix install for libbpf's internal header(s) > > bpftool: do not FORCE-build libbpf > > bpftool: turn check on zlib from a phony target into a conditional > > error > > > > tools/bpf/bpftool/Makefile | 29 +++++++++++++++-------------- > > 1 file changed, 15 insertions(+), 14 deletions(-) > > > > -- > > 2.30.2 > > > > I'm not a Makefile expert, but from my side these look good. Thanks. > > Acked-by: John Fastabend <john.fastabend@gmail.com> Applied to bpf-next, thanks.
This set contains one fix for bpftool's Makefile, to make sure that the headers internal to libbpf are installed properly even if we add more headers to the relevant Makefile variable in the future (although we'd like to avoid that if possible). The other patches aim at cleaning up the output from the Makefile, in particular when running the command "make" another time after bpftool is built. Quentin Monnet (3): bpftool: fix install for libbpf's internal header(s) bpftool: do not FORCE-build libbpf bpftool: turn check on zlib from a phony target into a conditional error tools/bpf/bpftool/Makefile | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-)