mbox series

[bpf-next,0/3] core_reloc fixes for s390

Message ID 20211021234653.643302-1-iii@linux.ibm.com (mailing list archive)
Headers show
Series core_reloc fixes for s390 | expand

Message

Ilya Leoshkevich Oct. 21, 2021, 11:46 p.m. UTC 
Hi,

this series fixes test failures in core_reloc on s390.

Patch 1 fixes a bug in byte order determination.
Patch 2 fixes an endianness issue in bitfield relocation.
Patch 3 fixes an endianness issue in test_core_reloc_mods.

Best regards,
Ilya

Ilya Leoshkevich (3):
  bpf: Use __BYTE_ORDER__ everywhere
  libbpf: Fix relocating big-endian bitfields
  selftests/bpf: Fix test_core_reloc_mods on big-endian machines

 samples/seccomp/bpf-helper.h                       |  8 ++++----
 tools/lib/bpf/bpf_core_read.h                      |  2 +-
 tools/lib/bpf/btf.c                                |  4 ++--
 tools/lib/bpf/btf_dump.c                           |  8 ++++----
 tools/lib/bpf/libbpf.c                             |  4 ++--
 tools/lib/bpf/linker.c                             | 12 ++++++------
 tools/lib/bpf/relo_core.c                          | 13 +++++++++----
 .../testing/selftests/bpf/prog_tests/btf_endian.c  |  6 +++---
 .../selftests/bpf/progs/test_core_reloc_mods.c     |  9 +++++++++
 tools/testing/selftests/bpf/test_sysctl.c          |  4 ++--
 tools/testing/selftests/bpf/verifier/ctx_skb.c     | 14 +++++++-------
 tools/testing/selftests/bpf/verifier/lwt.c         |  2 +-
 .../bpf/verifier/perf_event_sample_period.c        |  6 +++---
 tools/testing/selftests/seccomp/seccomp_bpf.c      |  6 +++---
 14 files changed, 56 insertions(+), 42 deletions(-)

Comments

Andrii Nakryiko Oct. 22, 2021, 11:38 p.m. UTC | #1 
On Thu, Oct 21, 2021 at 4:47 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>
> Hi,
>
> this series fixes test failures in core_reloc on s390.
>
> Patch 1 fixes a bug in byte order determination.
> Patch 2 fixes an endianness issue in bitfield relocation.
> Patch 3 fixes an endianness issue in test_core_reloc_mods.
>

This doesn't apply cleanly anymore. Please rebase and re-submit. You
mentioned that patch #2 is not necessary, so please drop it as well.
As for the patch #1, can you please split it into libbpf, selftests
and samples patches? Thanks.


> Best regards,
> Ilya
>
> Ilya Leoshkevich (3):
>   bpf: Use __BYTE_ORDER__ everywhere
>   libbpf: Fix relocating big-endian bitfields
>   selftests/bpf: Fix test_core_reloc_mods on big-endian machines
>
>  samples/seccomp/bpf-helper.h                       |  8 ++++----
>  tools/lib/bpf/bpf_core_read.h                      |  2 +-
>  tools/lib/bpf/btf.c                                |  4 ++--
>  tools/lib/bpf/btf_dump.c                           |  8 ++++----
>  tools/lib/bpf/libbpf.c                             |  4 ++--
>  tools/lib/bpf/linker.c                             | 12 ++++++------
>  tools/lib/bpf/relo_core.c                          | 13 +++++++++----
>  .../testing/selftests/bpf/prog_tests/btf_endian.c  |  6 +++---
>  .../selftests/bpf/progs/test_core_reloc_mods.c     |  9 +++++++++
>  tools/testing/selftests/bpf/test_sysctl.c          |  4 ++--
>  tools/testing/selftests/bpf/verifier/ctx_skb.c     | 14 +++++++-------
>  tools/testing/selftests/bpf/verifier/lwt.c         |  2 +-
>  .../bpf/verifier/perf_event_sample_period.c        |  6 +++---
>  tools/testing/selftests/seccomp/seccomp_bpf.c      |  6 +++---
>  14 files changed, 56 insertions(+), 42 deletions(-)
>
> --
> 2.31.1
>