mbox series

[bpf-next,v3,0/6] core_reloc fixes for s390

Message ID 20211026010831.748682-1-iii@linux.ibm.com (mailing list archive)
Headers show
Series core_reloc fixes for s390 | expand

Message

Ilya Leoshkevich Oct. 26, 2021, 1:08 a.m. UTC
v2: https://lore.kernel.org/bpf/20211025131214.731972-1-iii@linux.ibm.com/
v2 -> v3: Split the fix from the cleanup (Daniel).

v1: https://lore.kernel.org/bpf/20211021234653.643302-1-iii@linux.ibm.com/
v1 -> v2: Drop bpf_core_calc_field_relo() restructuring, split the
          __BYTE_ORDER__ change (Andrii).

Hi,

this series fixes test failures in core_reloc on s390.

Patch 1 fixes an endianness bug with __BYTE_ORDER vs __BYTE_ORDER__.
Patches 2-5 make the rest of the code consistent in that respect.
Patch 6 fixes an endianness issue in test_core_reloc_mods.

Best regards,
Ilya

Ilya Leoshkevich (6):
  libbpf: Fix endianness detection in BPF_CORE_READ_BITFIELD_PROBED()
  libbpf: Use __BYTE_ORDER__
  selftests/bpf: Use __BYTE_ORDER__
  samples: seccomp: use __BYTE_ORDER__
  selftests/seccomp: Use __BYTE_ORDER__
  selftests/bpf: Fix test_core_reloc_mods on big-endian machines

 samples/seccomp/bpf-helper.h                       |  8 ++++----
 tools/lib/bpf/bpf_core_read.h                      |  2 +-
 tools/lib/bpf/btf.c                                |  4 ++--
 tools/lib/bpf/btf_dump.c                           |  8 ++++----
 tools/lib/bpf/libbpf.c                             |  4 ++--
 tools/lib/bpf/linker.c                             | 12 ++++++------
 tools/lib/bpf/relo_core.c                          |  2 +-
 .../testing/selftests/bpf/prog_tests/btf_endian.c  |  6 +++---
 .../selftests/bpf/progs/test_core_reloc_mods.c     |  9 +++++++++
 tools/testing/selftests/bpf/test_sysctl.c          |  4 ++--
 tools/testing/selftests/bpf/verifier/ctx_skb.c     | 14 +++++++-------
 tools/testing/selftests/bpf/verifier/lwt.c         |  2 +-
 .../bpf/verifier/perf_event_sample_period.c        |  6 +++---
 tools/testing/selftests/seccomp/seccomp_bpf.c      |  6 +++---
 14 files changed, 48 insertions(+), 39 deletions(-)

Comments

Andrii Nakryiko Oct. 26, 2021, 3:40 a.m. UTC | #1
On Mon, Oct 25, 2021 at 6:08 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>
> v2: https://lore.kernel.org/bpf/20211025131214.731972-1-iii@linux.ibm.com/
> v2 -> v3: Split the fix from the cleanup (Daniel).
>
> v1: https://lore.kernel.org/bpf/20211021234653.643302-1-iii@linux.ibm.com/
> v1 -> v2: Drop bpf_core_calc_field_relo() restructuring, split the
>           __BYTE_ORDER__ change (Andrii).
>
> Hi,
>
> this series fixes test failures in core_reloc on s390.
>
> Patch 1 fixes an endianness bug with __BYTE_ORDER vs __BYTE_ORDER__.
> Patches 2-5 make the rest of the code consistent in that respect.
> Patch 6 fixes an endianness issue in test_core_reloc_mods.
>

Applied to bpf-next, thanks.

> Best regards,
> Ilya
>
> Ilya Leoshkevich (6):
>   libbpf: Fix endianness detection in BPF_CORE_READ_BITFIELD_PROBED()
>   libbpf: Use __BYTE_ORDER__
>   selftests/bpf: Use __BYTE_ORDER__
>   samples: seccomp: use __BYTE_ORDER__
>   selftests/seccomp: Use __BYTE_ORDER__
>   selftests/bpf: Fix test_core_reloc_mods on big-endian machines
>
>  samples/seccomp/bpf-helper.h                       |  8 ++++----
>  tools/lib/bpf/bpf_core_read.h                      |  2 +-
>  tools/lib/bpf/btf.c                                |  4 ++--
>  tools/lib/bpf/btf_dump.c                           |  8 ++++----
>  tools/lib/bpf/libbpf.c                             |  4 ++--
>  tools/lib/bpf/linker.c                             | 12 ++++++------
>  tools/lib/bpf/relo_core.c                          |  2 +-
>  .../testing/selftests/bpf/prog_tests/btf_endian.c  |  6 +++---
>  .../selftests/bpf/progs/test_core_reloc_mods.c     |  9 +++++++++
>  tools/testing/selftests/bpf/test_sysctl.c          |  4 ++--
>  tools/testing/selftests/bpf/verifier/ctx_skb.c     | 14 +++++++-------
>  tools/testing/selftests/bpf/verifier/lwt.c         |  2 +-
>  .../bpf/verifier/perf_event_sample_period.c        |  6 +++---
>  tools/testing/selftests/seccomp/seccomp_bpf.c      |  6 +++---
>  14 files changed, 48 insertions(+), 39 deletions(-)
>
> --
> 2.31.1
>