mbox series

[0/3] Fix various bash constructs in tests

Message ID 20211028134828.65774-1-james.clark@arm.com (mailing list archive)
Headers show
Series Fix various bash constructs in tests | expand

Message

James Clark Oct. 28, 2021, 1:48 p.m. UTC
These tests were either failing or printing warnings on my Ubuntu 18
and 20 systems. I'm not sure if there is a system where /bin/sh allows
bash constructs, or perf invokes bash instead of sh, but I saw that
there have been similar fixes made in the past so I assume this should
be done.

Adding set -e to the scripts didn't highlight these issues, so I didn't
do it at this time.

For stat_bpf_counters.sh, there are further bashisms after the skip,
but I couldn't get BPF working, so I only fixed it up to that point.

Applies to perf/core 624ff63abfd36

James Clark (3):
  perf test: Remove bash construct from stat_bpf_counters.sh test
  perf tests: Remove bash construct from record+zstd_comp_decomp.sh
  perf tests: Remove bash constructs from stat_all_pmu.sh

 tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +-
 tools/perf/tests/shell/stat_all_pmu.sh            | 4 ++--
 tools/perf/tests/shell/stat_bpf_counters.sh       | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)