From patchwork Thu Oct 28 13:48:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Clark X-Patchwork-Id: 12590235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9A6C4332F for ; Thu, 28 Oct 2021 13:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AE6D61056 for ; Thu, 28 Oct 2021 13:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230282AbhJ1NvK (ORCPT ); Thu, 28 Oct 2021 09:51:10 -0400 Received: from foss.arm.com ([217.140.110.172]:55078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbhJ1NvK (ORCPT ); Thu, 28 Oct 2021 09:51:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9FB471FB; Thu, 28 Oct 2021 06:48:42 -0700 (PDT) Received: from e121896.Emea.Arm.com (e121896.Emea.Arm.com [10.32.36.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 50F523F70D; Thu, 28 Oct 2021 06:48:38 -0700 (PDT) From: James Clark To: acme@kernel.org, linux-perf-users@vger.kernel.org, f.fainelli@gmail.com, irogers@google.com Cc: James Clark , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Thomas Richter , Sumanth Korikkar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 0/3] Fix various bash constructs in tests Date: Thu, 28 Oct 2021 14:48:24 +0100 Message-Id: <20211028134828.65774-1-james.clark@arm.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org These tests were either failing or printing warnings on my Ubuntu 18 and 20 systems. I'm not sure if there is a system where /bin/sh allows bash constructs, or perf invokes bash instead of sh, but I saw that there have been similar fixes made in the past so I assume this should be done. Adding set -e to the scripts didn't highlight these issues, so I didn't do it at this time. For stat_bpf_counters.sh, there are further bashisms after the skip, but I couldn't get BPF working, so I only fixed it up to that point. Applies to perf/core 624ff63abfd36 James Clark (3): perf test: Remove bash construct from stat_bpf_counters.sh test perf tests: Remove bash construct from record+zstd_comp_decomp.sh perf tests: Remove bash constructs from stat_all_pmu.sh tools/perf/tests/shell/record+zstd_comp_decomp.sh | 2 +- tools/perf/tests/shell/stat_all_pmu.sh | 4 ++-- tools/perf/tests/shell/stat_bpf_counters.sh | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)