mbox series

[iproute2-next,0/4] vdpa tool to query and set config layout

Message ID 20211202042239.2454-1-parav@nvidia.com (mailing list archive)
Headers show
Series vdpa tool to query and set config layout | expand

Message

Parav Pandit Dec. 2, 2021, 4:22 a.m. UTC
This series implements querying and setting of the mac address and mtu
device config fields of the vdpa device of type net.

An example of query and set as below.

$ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000

$ vdpa dev config show
bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000

$ vdpa dev config show -jp
{
    "config": {
        "bar": {
            "mac": "00:11:22:33:44:55",
            "link ": "up",
            "link_announce ": false,
            "mtu": 1500,
        }
    }
}

patch summary:
patch-1 updates the kernel headers
patch-2 implements the query command
patch-3 implements setting the mac address of vdpa dev config space
patch-4 implements setting the mtu of vdpa dev config space


Parav Pandit (4):
  vdpa: Update kernel headers
  vdpa: Enable user to query vdpa device config layout
  vdpa: Enable user to set mac address of vdpa device
  vdpa: Enable user to set mtu of the vdpa device

 include/uapi/linux/virtio_net.h |  81 +++++++++++++
 vdpa/include/uapi/linux/vdpa.h  |   7 ++
 vdpa/vdpa.c                     | 198 ++++++++++++++++++++++++++++++--
 3 files changed, 277 insertions(+), 9 deletions(-)
 create mode 100644 include/uapi/linux/virtio_net.h

Comments

David Ahern Dec. 3, 2021, 4:56 p.m. UTC | #1
On 12/1/21 9:22 PM, Parav Pandit wrote:
> This series implements querying and setting of the mac address and mtu
> device config fields of the vdpa device of type net.
> 
> An example of query and set as below.
> 
> $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu 9000
> 
> $ vdpa dev config show
> bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000
> 
> $ vdpa dev config show -jp
> {
>     "config": {
>         "bar": {
>             "mac": "00:11:22:33:44:55",
>             "link ": "up",
>             "link_announce ": false,
>             "mtu": 1500,
>         }
>     }
> }
> 
> patch summary:
> patch-1 updates the kernel headers
> patch-2 implements the query command
> patch-3 implements setting the mac address of vdpa dev config space
> patch-4 implements setting the mtu of vdpa dev config space
> 
> 
> Parav Pandit (4):
>   vdpa: Update kernel headers
>   vdpa: Enable user to query vdpa device config layout
>   vdpa: Enable user to set mac address of vdpa device
>   vdpa: Enable user to set mtu of the vdpa device
> 
>  include/uapi/linux/virtio_net.h |  81 +++++++++++++
>  vdpa/include/uapi/linux/vdpa.h  |   7 ++
>  vdpa/vdpa.c                     | 198 ++++++++++++++++++++++++++++++--
>  3 files changed, 277 insertions(+), 9 deletions(-)
>  create mode 100644 include/uapi/linux/virtio_net.h
> 

please update man page(s)
Parav Pandit Dec. 13, 2021, 5:58 a.m. UTC | #2
> From: David Ahern <dsahern@gmail.com>
> Sent: Friday, December 3, 2021 10:27 PM
> 
> On 12/1/21 9:22 PM, Parav Pandit wrote:
> > This series implements querying and setting of the mac address and mtu
> > device config fields of the vdpa device of type net.
> >
> > An example of query and set as below.
> >
> > $ vdpa dev add name bar mgmtdev vdpasim_net mac 00:11:22:33:44:55 mtu
> > 9000
> >
> > $ vdpa dev config show
> > bar: mac 00:11:22:33:44:55 link up link_announce false mtu 9000
> >
> > $ vdpa dev config show -jp
> > {
> >     "config": {
> >         "bar": {
> >             "mac": "00:11:22:33:44:55",
> >             "link ": "up",
> >             "link_announce ": false,
> >             "mtu": 1500,
> >         }
> >     }
> > }
> >
> > patch summary:
> > patch-1 updates the kernel headers
> > patch-2 implements the query command
> > patch-3 implements setting the mac address of vdpa dev config space
> > patch-4 implements setting the mtu of vdpa dev config space
> >
> >
> > Parav Pandit (4):
> >   vdpa: Update kernel headers
> >   vdpa: Enable user to query vdpa device config layout
> >   vdpa: Enable user to set mac address of vdpa device
> >   vdpa: Enable user to set mtu of the vdpa device
> >
> >  include/uapi/linux/virtio_net.h |  81 +++++++++++++
> >  vdpa/include/uapi/linux/vdpa.h  |   7 ++
> >  vdpa/vdpa.c                     | 198 ++++++++++++++++++++++++++++++--
> >  3 files changed, 277 insertions(+), 9 deletions(-)  create mode
> > 100644 include/uapi/linux/virtio_net.h
> >
> 
> please update man page(s)
Ok. I will update them and also update patches to address comments in other two patches in v2.
Thanks.