mbox series

[net-next,0/2] tcp: take care of another syzbot issue

Message ID 20220222032113.4005821-1-eric.dumazet@gmail.com (mailing list archive)
Headers show
Series tcp: take care of another syzbot issue | expand

Message

Eric Dumazet Feb. 22, 2022, 3:21 a.m. UTC
From: Eric Dumazet <edumazet@google.com>

This is a minor issue: It took months for syzbot to find a C repro,
and even with it, I had to spend a lot of time to understand KFENCE
was a prereq. With the default kfence 500ms interval, I had to be
very patient to trigger the kernel warning and perform my analysis.

This series targets net-next tree, because I added a new generic helper
in the first patch, then fixed the issue in the second one.
They can be backported once proven solid.

Eric Dumazet (2):
  net: add skb_set_end_offset() helper
  net: preserve skb_end_offset() in skb_unclone_keeptruesize()

 include/linux/skbuff.h | 30 +++++++++++++++++--------
 net/core/skbuff.c      | 51 ++++++++++++++++++++++++++++++------------
 2 files changed, 58 insertions(+), 23 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 23, 2022, 4:10 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 21 Feb 2022 19:21:11 -0800 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> This is a minor issue: It took months for syzbot to find a C repro,
> and even with it, I had to spend a lot of time to understand KFENCE
> was a prereq. With the default kfence 500ms interval, I had to be
> very patient to trigger the kernel warning and perform my analysis.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: add skb_set_end_offset() helper
    https://git.kernel.org/netdev/net-next/c/763087dab975
  - [net-next,2/2] net: preserve skb_end_offset() in skb_unclone_keeptruesize()
    (no matching commit)

You are awesome, thank you!
Jakub Kicinski Feb. 23, 2022, 4:15 a.m. UTC | #2
On Wed, 23 Feb 2022 04:10:10 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
>   - [net-next,2/2] net: preserve skb_end_offset() in skb_unclone_keeptruesize()
>     (no matching commit)

I dropped the extra new lines around the body of
skb_unclone_keeptruesize()
Eric Dumazet Feb. 23, 2022, 4:48 a.m. UTC | #3
On Tue, Feb 22, 2022 at 8:15 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 23 Feb 2022 04:10:10 +0000 patchwork-bot+netdevbpf@kernel.org
> wrote:
> >   - [net-next,2/2] net: preserve skb_end_offset() in skb_unclone_keeptruesize()
> >     (no matching commit)
>
> I dropped the extra new lines around the body of
> skb_unclone_keeptruesize()

Thanks !