| Message ID | 20220317165826.1099418-1-jakub@cloudflare.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Make 2-byte access to bpf_sk_lookup->remote_port endian-agnostic | expand |
On Thu, Mar 17, 2022 at 05:58:23PM +0100, Jakub Sitnicki wrote: > This patch set is a result of a discussion we had around the RFC patchset from > Ilya [1]. The fix for the narrow loads from the RFC series is still relevant, > but this series does not depend on it. Nor is it required to unbreak sk_lookup > tests on BE, if this series gets applied. > > To summarize the takeaways from [1]: > > 1) we want to make 2-byte load from ctx->remote_port portable across LE and BE, > 2) we keep the 4-byte load from ctx->remote_port as it is today - result varies > on endianess of the platform. > > [1] https://lore.kernel.org/bpf/20220222182559.2865596-2-iii@linux.ibm.com/ For the set, Acked-by: Martin KaFai Lau <kafai@fb.com>
This patch set is a result of a discussion we had around the RFC patchset from Ilya [1]. The fix for the narrow loads from the RFC series is still relevant, but this series does not depend on it. Nor is it required to unbreak sk_lookup tests on BE, if this series gets applied. To summarize the takeaways from [1]: 1) we want to make 2-byte load from ctx->remote_port portable across LE and BE, 2) we keep the 4-byte load from ctx->remote_port as it is today - result varies on endianess of the platform. [1] https://lore.kernel.org/bpf/20220222182559.2865596-2-iii@linux.ibm.com/ Jakub Sitnicki (3): bpf: Treat bpf_sk_lookup remote_port as a 2-byte field selftests/bpf: Fix u8 narrow load checks for bpf_sk_lookup remote_port selftests/bpf: Fix test for 4-byte load from remote_port on big-endian net/core/filter.c | 20 +++++++++++++++++-- .../selftests/bpf/progs/test_sk_lookup.c | 13 ++++++++---- 2 files changed, 27 insertions(+), 6 deletions(-)