mbox series

[v2,net-next,0/5] net: CONFIG_DEBUG_NET and friends

Message ID 20220510035741.2807829-1-eric.dumazet@gmail.com (mailing list archive)
Headers show
Series net: CONFIG_DEBUG_NET and friends | expand

Message

Eric Dumazet May 10, 2022, 3:57 a.m. UTC
From: Eric Dumazet <edumazet@google.com>

This patch series is inspired by some syzbot reports
hinting that skb transport_header might be not set
in places we expect it being set.

Add a new CONFIG_DEBUG_NET option
and DEBUG_NET_WARN_ON_ONCE() helper, so that we can start
adding more sanity checks in the future.

Replace two BUG() in skb_checksum_help()
with less risky code.

v2: make first patch compile on more arches/compilers
    add the 5th patch to add more debugging in skb_checksum_help()

Eric Dumazet (5):
  net: add include/net/net_debug.h
  net: add CONFIG_DEBUG_NET
  net: warn if transport header was not set
  net: remove two BUG() from skb_checksum_help()
  net: add more debug info in skb_checksum_help()

 include/linux/netdevice.h | 141 +---------------------------------
 include/linux/skbuff.h    |   2 +
 include/net/net_debug.h   | 157 ++++++++++++++++++++++++++++++++++++++
 net/Kconfig.debug         |   7 ++
 net/core/dev.c            |  12 ++-
 5 files changed, 176 insertions(+), 143 deletions(-)
 create mode 100644 include/net/net_debug.h

Comments

patchwork-bot+netdevbpf@kernel.org May 11, 2022, noon UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Mon,  9 May 2022 20:57:36 -0700 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> This patch series is inspired by some syzbot reports
> hinting that skb transport_header might be not set
> in places we expect it being set.
> 
> Add a new CONFIG_DEBUG_NET option
> and DEBUG_NET_WARN_ON_ONCE() helper, so that we can start
> adding more sanity checks in the future.
> 
> [...]

Here is the summary with links:
  - [v2,net-next,1/5] net: add include/net/net_debug.h
    https://git.kernel.org/netdev/net-next/c/5b87be9e4978
  - [v2,net-next,2/5] net: add CONFIG_DEBUG_NET
    https://git.kernel.org/netdev/net-next/c/d268c1f5cfc9
  - [v2,net-next,3/5] net: warn if transport header was not set
    (no matching commit)
  - [v2,net-next,4/5] net: remove two BUG() from skb_checksum_help()
    https://git.kernel.org/netdev/net-next/c/d7ea0d9df2a6
  - [v2,net-next,5/5] net: add more debug info in skb_checksum_help()
    https://git.kernel.org/netdev/net-next/c/eeee4b77dc52

You are awesome, thank you!