mbox series

[net-next,0/4] mptcp: Miscellaneous fixes and a new test case

Message ID 20220518220446.209750-1-mathew.j.martineau@linux.intel.com (mailing list archive)
Headers show
Series mptcp: Miscellaneous fixes and a new test case | expand

Message

Mat Martineau May 18, 2022, 10:04 p.m. UTC 
Patches 1 and 3 remove helpers that were iterating over the subflow
connection list without proper locking. Iteration was not needed in
either case.

Patch 2 fixes handling of MP_FAIL timeout, checking for orphaned
subflows instead of using the MPTCP socket data lock and connection
state.

Patch 4 adds a test for MP_FAIL timeout using tc pedit to induce checksum
failures.

Geliang Tang (1):
  selftests: mptcp: add MP_FAIL reset testcase

Mat Martineau (2):
  mptcp: Check for orphaned subflow before handling MP_FAIL timer
  mptcp: Do not traverse the subflow connection list without lock

Paolo Abeni (1):
  mptcp: stop using the mptcp_has_another_subflow() helper

 net/mptcp/pm.c                                  |  9 +++------
 net/mptcp/protocol.c                            | 16 +---------------
 net/mptcp/protocol.h                            | 14 --------------
 net/mptcp/subflow.c                             | 15 +++++----------
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 10 ++++++++++
 5 files changed, 19 insertions(+), 45 deletions(-)


base-commit: a3641ca416a3da7cbeae5bcf1fc26ba9797a1438

Comments

patchwork-bot+netdevbpf@kernel.org May 20, 2022, 3:10 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 18 May 2022 15:04:42 -0700 you wrote:
> Patches 1 and 3 remove helpers that were iterating over the subflow
> connection list without proper locking. Iteration was not needed in
> either case.
> 
> Patch 2 fixes handling of MP_FAIL timeout, checking for orphaned
> subflows instead of using the MPTCP socket data lock and connection
> state.
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] mptcp: stop using the mptcp_has_another_subflow() helper
    https://git.kernel.org/netdev/net-next/c/7b16871f9932
  - [net-next,2/4] mptcp: Check for orphaned subflow before handling MP_FAIL timer
    https://git.kernel.org/netdev/net-next/c/d42f9e4e2384
  - [net-next,3/4] mptcp: Do not traverse the subflow connection list without lock
    https://git.kernel.org/netdev/net-next/c/d9fb797046c5
  - [net-next,4/4] selftests: mptcp: add MP_FAIL reset testcase
    https://git.kernel.org/netdev/net-next/c/2ba18161d407

You are awesome, thank you!