mbox series

[net,0/3] dpaa2-eth: software TSO fixes

Message ID 20220522125251.444477-1-ioana.ciornei@nxp.com (mailing list archive)
Headers show
Series dpaa2-eth: software TSO fixes | expand

Message

Ioana Ciornei May 22, 2022, 12:52 p.m. UTC 
This patch fixes the software TSO feature in dpaa2-eth.

There are multiple errors that I made in the initial submission of the
code, which I didn't caught since I was always running with passthough
IOMMU.

The bug report came in bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=215886

The bugs are in the Tx confirmation path, where I was trying to retrieve
a virtual address after DMA unmapping the area. Besides that, another
dma_unmap call was made with the wrong size.

Ioana Ciornei (3):
  dpaa2-eth: retrieve the virtual address before dma_unmap
  dpaa2-eth: use the correct software annotation field
  dpaa2-eth: unmap the SGT buffer before accessing its contents

 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Jakub Kicinski May 24, 2022, 6:39 p.m. UTC | #1 
On Sun, 22 May 2022 15:52:48 +0300 Ioana Ciornei wrote:
> This patch fixes the software TSO feature in dpaa2-eth.
> 
> There are multiple errors that I made in the initial submission of the
> code, which I didn't caught since I was always running with passthough
> IOMMU.
> 
> The bug report came in bugzilla:
> https://bugzilla.kernel.org/show_bug.cgi?id=215886
> 
> The bugs are in the Tx confirmation path, where I was trying to retrieve
> a virtual address after DMA unmapping the area. Besides that, another
> dma_unmap call was made with the wrong size.

Thanks for the fixes! FTR it's been applied as commit 7e4d1c237592
("Merge branch 'dpaa2-swtso-fixes'") to net on Sunday.
David Lamparter June 1, 2022, 10:22 a.m. UTC | #2 
On Sun, May 22, 2022 at 03:52:48PM +0300, Ioana Ciornei wrote:
> This patch fixes the software TSO feature in dpaa2-eth.

Could I bug you to get these thrown into -stable?  5.18.1 is currently
unusable on LX2k (with IOMMU enabled).

Thanks,
David

(Apologies if it's already underway.)