mbox series

[net,0/2] sfc/siena: fix some efx_separate_tx_channels errors

Message ID 20220531134034.389792-1-ihuguet@redhat.com (mailing list archive)
Headers show
Series sfc/siena: fix some efx_separate_tx_channels errors | expand

Message

Íñigo Huguet May 31, 2022, 1:40 p.m. UTC 
Trying to load sfc driver with modparam efx_separate_tx_channels=1
resulted in errors during initialization and not being able to use the
NIC. This patches fix a few bugs and make it work again.

This has been already done in sfc, do it also in sfc_siena.

Martin Habets (1):
  sfc/siena: fix considering that all channels have TX queues

Íñigo Huguet (1):
  sfc/siena: fix wrong tx channel offset with efx_separate_tx_channels

 drivers/net/ethernet/sfc/siena/efx_channels.c | 6 ++----
 drivers/net/ethernet/sfc/siena/net_driver.h   | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

Comments

Jakub Kicinski May 31, 2022, 3:37 p.m. UTC | #1 
On Tue, 31 May 2022 15:40:32 +0200 Íñigo Huguet wrote:
> Trying to load sfc driver with modparam efx_separate_tx_channels=1
> resulted in errors during initialization and not being able to use the
> NIC. This patches fix a few bugs and make it work again.
> 
> This has been already done in sfc, do it also in sfc_siena.

Does not apply.
Íñigo Huguet June 1, 2022, 6:23 a.m. UTC | #2 
On Tue, May 31, 2022 at 5:38 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 31 May 2022 15:40:32 +0200 Íñigo Huguet wrote:
> > Trying to load sfc driver with modparam efx_separate_tx_channels=1
> > resulted in errors during initialization and not being able to use the
> > NIC. This patches fix a few bugs and make it work again.
> >
> > This has been already done in sfc, do it also in sfc_siena.
>
> Does not apply.
>

Sorry about that, I had only applied with patch, not with git, but it
applies with fuzz 1, as I'm seeing now, so not 100% cleanly. I will
send v2.