mbox series

[v2,net-next,0/2] af_unix: Fix regression by the per-netns hash table series.

Message ID 20220702014447.93746-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series af_unix: Fix regression by the per-netns hash table series. | expand

Message

Kuniyuki Iwashima July 2, 2022, 1:44 a.m. UTC 
The series 6dd4142fb5a9 ("Merge branch 'af_unix-per-netns-socket-hash'")
replaced a global hash table with per-netns tables, which caused regression
reported in the links below. [0][1]

When a pathname socket is visible, any socket, even in different netns,
has to be able to connect to it.  The series puts all sockets into each
namespace's hash table, making it impossible to look up a visible socket
in different netns.

On the other hand, while dumping sockets, they are filtered by netns.  To
keep such code simple, let's add a new global hash table only for pathname
sockets and link them with sk_bind_node.  Then we can keep all sockets in
each per-netns table and look up pathname sockets via the global table.

[0]: https://lore.kernel.org/netdev/B2AA3091-796D-475E-9A11-0021996E1C00@linux.ibm.com/
[1]: https://lore.kernel.org/netdev/5fb8d86f-b633-7552-8ba9-41e42f07c02a@gmail.com/


Kuniyuki Iwashima (2):
  af_unix: Put a named socket in the global hash table.
  selftests: net: af_unix: Test connect() with different netns.

 net/unix/af_unix.c                            |  47 ++++--
 tools/testing/selftests/net/.gitignore        |   1 +
 tools/testing/selftests/net/af_unix/Makefile  |   3 +-
 .../selftests/net/af_unix/unix_connect.c      | 149 ++++++++++++++++++
 4 files changed, 189 insertions(+), 11 deletions(-)
 create mode 100644 tools/testing/selftests/net/af_unix/unix_connect.c