From patchwork Sat Jul 9 00:04:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yosry Ahmed X-Patchwork-Id: 12911985 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282B2C433EF for ; Sat, 9 Jul 2022 00:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229605AbiGIAEu (ORCPT ); Fri, 8 Jul 2022 20:04:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiGIAEt (ORCPT ); Fri, 8 Jul 2022 20:04:49 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C65D8E6EF for ; Fri, 8 Jul 2022 17:04:48 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id bd7-20020a656e07000000b00412a946da8eso133438pgb.20 for ; Fri, 08 Jul 2022 17:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=HdWpX77+MF9xQ6/QsCAb26Y3cSwjCazeARYstERxxp8=; b=c8nDPxyekc1kZMkn/5QMcfPObZeIlCFyv+zxyjjPRxXd/7kkoFLhxc/JCpN4crPvkt J9LZ/p/TS41WmQuMzQEPLbD9Pi7C0D3d+pFs2juLvk/lQbtefWsqu8xv+UamdgslpXvs a1g9dygHhH25xVuDO9dMMQCs8a2eQ0J5/i/vkM464AZ5kK605FtPxqhQuBaQsS7Ly3cP kwS1qUJsPBw0nDu+ULP8xdgttiZcylEzCWfqSWCj14118YVczwj8y3AyNYtxwx9437K9 HjWJT4b3yDDfDUA18+MGf5iDyx2bKDbxD0rkZma25w4xvxd5mYFNHZUoYNGIGmQaruAL 8BtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=HdWpX77+MF9xQ6/QsCAb26Y3cSwjCazeARYstERxxp8=; b=EAWJFon3VNyhOPx+MDRVyYPItfhaRIKbdkmIlhXY2wz2U1HyEiTXDfxujN5cjy4t42 Njq32Df4UkxWOFi7E30fb/Z2UMPlOTyEG4IITSrqnflvfLl9PyhCxtakd0J0sPM1ssrd rgp5sWbMZaQUHrUjDwE3JKb/nH3Vp6WqWeQ3DDxbC5N118RqLxRuxeGNdKLutysbhHL1 sayYYChL5kst8WzwlbeZWa3ODtw5ohb2EKc91LPm0MzLcN27S1NT8hjsvlVxF27bfQHM /lHLgV4yBaEpMPWYwS4Nx+AKnPdXH/the5uXUh1ksUM8cvxtBLSlNEEOCmnSdhz5sRnG aQ0g== X-Gm-Message-State: AJIora/Q9fZhfWYE5LbSWBP/N429DjSv1MUZRbZ6Ko9+er6Yl6c0f+QY RI/JdrtHHm1IKulDr50+uCHefC5a1UW3udPE X-Google-Smtp-Source: AGRyM1uff0VlMUx44kyB6tai5qXVXBxhkwYUpgSibZ1YrCtqfn9IpwEkXBePF1JFzG+v9adORSKqsrdWM9KLLV7w X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:2327]) (user=yosryahmed job=sendgmr) by 2002:a17:902:76c8:b0:16c:1c13:9eea with SMTP id j8-20020a17090276c800b0016c1c139eeamr5994811plt.83.1657325087468; Fri, 08 Jul 2022 17:04:47 -0700 (PDT) Date: Sat, 9 Jul 2022 00:04:31 +0000 Message-Id: <20220709000439.243271-1-yosryahmed@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.0.rc0.161.g10f37bed90-goog Subject: [PATCH bpf-next v3 0/8] bpf: rstat: cgroup hierarchical stats From: Yosry Ahmed To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , Hao Luo , Tejun Heo , Zefan Li Cc: Johannes Weiner , Shuah Khan , Michal Hocko , KP Singh , Benjamin Tissoires , John Fastabend , " =?utf-8?q?Michal_Koutn=C3=BD?= " , Roman Gushchin , David Rientjes , Stanislav Fomichev , Greg Thelen , Shakeel Butt , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, Yosry Ahmed Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: bpf@iogearbox.net s patch series allows for using bpf to collect hierarchical cgroup stats efficiently by integrating with the rstat framework. The rstat framework provides an efficient way to collect cgroup stats percpu and propagate them through the cgroup hierarchy. The stats are exposed to userspace in textual form by reading files in bpffs, similar to cgroupfs stats by using a cgroup_iter program. cgroup_iter is a type of bpf_iter. It walks over cgroups in three modes: - walking a cgroup's descendants in pre-order. - walking a cgroup's descendants in post-order. - walking a cgroup's ancestors. When attaching cgroup_iter, one needs to set a cgroup to the iter_link created from attaching. This cgroup is passed as a file descriptor and serves as the starting point of the walk. One can also terminate the walk early by returning 1 from the iter program. Note that because walking cgroup hierarchy holds cgroup_mutex, the iter program is called with cgroup_mutex held. ** Background on rstat for stats collection ** (I am using a subscriber analogy that is not commonly used) The rstat framework maintains a tree of cgroups that have updates and which cpus have updates. A subscriber to the rstat framework maintains their own stats. The framework is used to tell the subscriber when and what to flush, for the most efficient stats propagation. The workflow is as follows: - When a subscriber updates a cgroup on a cpu, it informs the rstat framework by calling cgroup_rstat_updated(cgrp, cpu). - When a subscriber wants to read some stats for a cgroup, it asks the rstat framework to initiate a stats flush (propagation) by calling cgroup_rstat_flush(cgrp). - When the rstat framework initiates a flush, it makes callbacks to subscribers to aggregate stats on cpus that have updates, and propagate updates to their parent. Currently, the main subscribers to the rstat framework are cgroup subsystems (e.g. memory, block). This patch series allow bpf programs to become subscribers as well. This patch series includes a resend of a patch from the mailing list by Benjamin Tissoires to support sleepable kfuncs [1]. Patches in this series are organized as follows: * Patch 1 is the resend of the sleepable kfuncs patch [1]. * Patch 2 enables the use of cgroup_get_from_file() in cgroup1. This is useful because it enables cgroup_iter to work with cgroup1, and allows the entire stat collection workflow to be cgroup1-compatible. * Patches 3-5 introduce cgroup_iter prog, and a selftest. * Patches 6-8 allow bpf programs to integrate with rstat by adding the necessary hook points and kfunc. A comprehensive selftest that demonstrates the entire workflow for using bpf and rstat to efficiently collect and output cgroup stats is added. --- Changelog: v2 -> v3: - cgroup_iter: * Added conditional compilation of cgroup_iter.c in kernel/bpf/Makefile (kernel test) and dropped the !CONFIG_CGROUP patch. * Added validation of traversal_order when attaching (Yonghong). * Fixed previous wording "two modes" to "three modes" (Yonghong). * Fixed the btf_dump selftest broken by this patch (Yonghong). * Fixed ctx_arg_info[0] to use "PTR_TO_BTF_ID_OR_NULL" instead of "PTR_TO_BTF_ID", because the "cgroup" pointer passed to iter prog can be null. - Use __diag_push to eliminate __weak noinline warning in bpf_rstat_flush(). - cgroup_hierarchical_stats selftest: * Added write_cgroup_file_parent() helper. * Added error handling for failed map updates. * Added null check for cgroup in vmscan_flush. * Fixed the signature of vmscan_[start/end]. * Correctly return error code when attaching trace programs fail. * Make sure all links are destroyed correctly and not leaking in cgroup_hierarchical_stats selftest. * Use memory.reclaim instead of memory.high as a more reliable way to invoke reclaim. * Eliminated sleeps, the test now runs faster. v1 -> v2: - Redesign of cgroup_iter from v1, based on Alexei's idea [2]: * supports walking cgroup subtree. * supports walking ancestors of a cgroup. (Andrii) * supports terminating the walk early. * uses fd instead of cgroup_id as parameter for iter_link. Using fd is a convention in bpf. * gets cgroup's ref at attach time and deref at detach. * brought back cgroup1 support for cgroup_iter. - Squashed the patches adding the rstat flush hook points and kfuncs (Tejun). - Added a comment explaining why bpf_rstat_flush() needs to be weak (Tejun). - Updated the final selftest with the new cgroup_iter design. - Changed CHECKs in the selftest with ASSERTs (Yonghong, Andrii). - Removed empty line at the end of the selftest (Yonghong). - Renamed test files to cgroup_hierarchical_stats.c. - Reordered CGROUP_PATH params order to match struct declaration in the selftest (Michal). - Removed memory_subsys_enabled() and made sure memcg controller enablement checks make sense and are documented (Michal). RFC v2 -> v1: - Instead of introducing a new program type for rstat flushing, add an empty hook point, bpf_rstat_flush(), and use fentry bpf programs to attach to it and flush bpf stats. - Instead of using helpers, use kfuncs for rstat functions. - These changes simplify the patchset greatly, with minimal changes to uapi. RFC v1 -> RFC v2: - Instead of rstat flush programs attach to subsystems, they now attach to rstat (global flushers, not per-subsystem), based on discussions with Tejun. The first patch is entirely rewritten. - Pass cgroup pointers to rstat flushers instead of cgroup ids. This is much more flexibility and less likely to need a uapi update later. - rstat helpers are now only defined if CGROUP_CONFIG. - Most of the code is now only defined if CGROUP_CONFIG and CONFIG_BPF_SYSCALL. - Move rstat helper protos from bpf_base_func_proto() to tracing_prog_func_proto(). - rstat helpers argument (cgroup pointer) is now ARG_PTR_TO_BTF_ID, not ARG_ANYTHING. - Rewrote the selftest to use the cgroup helpers. - Dropped bpf_map_lookup_percpu_elem (already added by Feng). - Dropped patch to support cgroup v1 for cgroup_iter. - Dropped patch to define some cgroup_put() when !CONFIG_CGROUP. The code that calls it is no longer compiled when !CONFIG_CGROUP. cgroup_iter was originally introduced in a different patch series[3]. Hao and I agreed that it fits better as part of this series. RFC v1 of this patch series had the following changes from [3]: - Getting the cgroup's reference at the time at attaching, instead of at the time when iterating. (Yonghong) - Remove .init_seq_private and .fini_seq_private callbacks for cgroup_iter. They are not needed now. (Yonghong) [1] https://lore.kernel.org/bpf/20220421140740.459558-5-benjamin.tissoires@redhat.com/ [2] https://lore.kernel.org/bpf/20220520221919.jnqgv52k4ajlgzcl@MBP-98dd607d3435.dhcp.thefacebook.com/ [3] https://lore.kernel.org/lkml/20220225234339.2386398-9-haoluo@google.com/ --- Benjamin Tissoires (1): btf: Add a new kfunc set which allows to mark a function to be sleepable Hao Luo (3): bpf, iter: Fix the condition on p when calling stop. bpf: Introduce cgroup iter selftests/bpf: Test cgroup_iter. Yosry Ahmed (4): cgroup: enable cgroup_get_from_file() on cgroup1 cgroup: bpf: enable bpf programs to integrate with rstat selftests/bpf: extend cgroup helpers bpf: add a selftest for cgroup hierarchical stats collection include/linux/bpf.h | 8 + include/linux/btf.h | 2 + include/uapi/linux/bpf.h | 21 + kernel/bpf/Makefile | 3 + kernel/bpf/bpf_iter.c | 5 + kernel/bpf/btf.c | 13 +- kernel/bpf/cgroup_iter.c | 242 ++++++++++++ kernel/cgroup/cgroup.c | 5 - kernel/cgroup/rstat.c | 54 +++ tools/include/uapi/linux/bpf.h | 21 + tools/testing/selftests/bpf/cgroup_helpers.c | 201 ++++++++-- tools/testing/selftests/bpf/cgroup_helpers.h | 19 +- .../selftests/bpf/prog_tests/btf_dump.c | 4 +- .../prog_tests/cgroup_hierarchical_stats.c | 362 ++++++++++++++++++ .../selftests/bpf/prog_tests/cgroup_iter.c | 190 +++++++++ tools/testing/selftests/bpf/progs/bpf_iter.h | 7 + .../bpf/progs/cgroup_hierarchical_stats.c | 235 ++++++++++++ .../testing/selftests/bpf/progs/cgroup_iter.c | 39 ++ 18 files changed, 1375 insertions(+), 56 deletions(-) create mode 100644 kernel/bpf/cgroup_iter.c create mode 100644 tools/testing/selftests/bpf/prog_tests/cgroup_hierarchical_stats.c create mode 100644 tools/testing/selftests/bpf/prog_tests/cgroup_iter.c create mode 100644 tools/testing/selftests/bpf/progs/cgroup_hierarchical_stats.c create mode 100644 tools/testing/selftests/bpf/progs/cgroup_iter.c