| Message ID | 20220714024612.944071-1-pulehui@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use lightweigt version of bpftool | expand |
On Wed, Jul 13, 2022 at 7:16 PM Pu Lehui <pulehui@huawei.com> wrote: > > Currently, samples/bpf, tools/runqslower and bpf/iterators use bpftool > for vmlinux.h, skeleton, and static linking only. We can uselightweight > bootstrap version of bpftool to handle these, and it will be faster. > > v2: > - make libbpf and bootstrap bpftool independent. and make it simple. > Quentin, does this patch set look good to you? > v1: https://lore.kernel.org/bpf/20220712030813.865410-1-pulehui@huawei.com > > Pu Lehui (3): > samples: bpf: Fix cross-compiling error by using bootstrap bpftool > tools: runqslower: build and use lightweight bootstrap version of > bpftool > bpf: iterators: build and use lightweight bootstrap version of bpftool > > kernel/bpf/preload/iterators/Makefile | 10 +++------- > samples/bpf/Makefile | 10 ++++------ > tools/bpf/runqslower/Makefile | 7 +++---- > 3 files changed, 10 insertions(+), 17 deletions(-) > > -- > 2.25.1 >
On 15/07/2022 17:56, Andrii Nakryiko wrote: > On Wed, Jul 13, 2022 at 7:16 PM Pu Lehui <pulehui@huawei.com> wrote: >> >> Currently, samples/bpf, tools/runqslower and bpf/iterators use bpftool >> for vmlinux.h, skeleton, and static linking only. We can uselightweight >> bootstrap version of bpftool to handle these, and it will be faster. >> >> v2: >> - make libbpf and bootstrap bpftool independent. and make it simple. >> > > Quentin, does this patch set look good to you? [Apologies, the mail server has been filtering Pu's emails as spam for some reason and I had missed the discussion :s] Looks OK to me: Acked-by: Quentin Monnet <quentin@isovalent.com> Although I'm a bit sorry to see the sharing of libbpf between bpftool and libbpf go away. But OK. We can maybe reintroduce it through bpftool's Makefile or a separate include Makefile in the future. Quentin
Hello: This series was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Thu, 14 Jul 2022 10:46:09 +0800 you wrote: > Currently, samples/bpf, tools/runqslower and bpf/iterators use bpftool > for vmlinux.h, skeleton, and static linking only. We can uselightweight > bootstrap version of bpftool to handle these, and it will be faster. > > v2: > - make libbpf and bootstrap bpftool independent. and make it simple. > > [...] Here is the summary with links: - [bpf-next,v2,1/3] samples: bpf: Fix cross-compiling error by using bootstrap bpftool https://git.kernel.org/bpf/bpf-next/c/2e4966288c16 - [bpf-next,v2,2/3] tools: runqslower: build and use lightweight bootstrap version of bpftool https://git.kernel.org/bpf/bpf-next/c/3a2a58c4479a - [bpf-next,v2,3/3] bpf: iterators: build and use lightweight bootstrap version of bpftool https://git.kernel.org/bpf/bpf-next/c/3848636b4a88 You are awesome, thank you!
On 2022/7/16 1:15, Quentin Monnet wrote: > On 15/07/2022 17:56, Andrii Nakryiko wrote: >> On Wed, Jul 13, 2022 at 7:16 PM Pu Lehui <pulehui@huawei.com> wrote: >>> >>> Currently, samples/bpf, tools/runqslower and bpf/iterators use bpftool >>> for vmlinux.h, skeleton, and static linking only. We can uselightweight >>> bootstrap version of bpftool to handle these, and it will be faster. >>> >>> v2: >>> - make libbpf and bootstrap bpftool independent. and make it simple. >>> >> >> Quentin, does this patch set look good to you? > > [Apologies, the mail server has been filtering Pu's emails as spam for > some reason and I had missed the discussion :s] > > Looks OK to me: > Acked-by: Quentin Monnet <quentin@isovalent.com> > > Although I'm a bit sorry to see the sharing of libbpf between bpftool > and libbpf go away. But OK. We can maybe reintroduce it through > bpftool's Makefile or a separate include Makefile in the future. > > Quentin > . Hi, Quentin, so much thanks for your review and ack. and apologies for not receiving your advice in time due to the misconfiguration of mail server[0]. and looking forward to your improvement for bpftool. [0]https://lore.kernel.org/all/20220523152516.7sr247i3bzwhr44w@quack3.lan/ >
Currently, samples/bpf, tools/runqslower and bpf/iterators use bpftool for vmlinux.h, skeleton, and static linking only. We can uselightweight bootstrap version of bpftool to handle these, and it will be faster. v2: - make libbpf and bootstrap bpftool independent. and make it simple. v1: https://lore.kernel.org/bpf/20220712030813.865410-1-pulehui@huawei.com Pu Lehui (3): samples: bpf: Fix cross-compiling error by using bootstrap bpftool tools: runqslower: build and use lightweight bootstrap version of bpftool bpf: iterators: build and use lightweight bootstrap version of bpftool kernel/bpf/preload/iterators/Makefile | 10 +++------- samples/bpf/Makefile | 10 ++++------ tools/bpf/runqslower/Makefile | 7 +++---- 3 files changed, 10 insertions(+), 17 deletions(-)